Add context manager for allowing unresolved templates and make the state members private #4735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both (templating and disabling the enforcing) should only be disabled temporarily so make the state private and expose only the context manager and a property.
2 small fixes in adjacent code:
resolve_template
member instead of the free function to remove some C&P codeI also intended to make
asdict
trivial (see 2a63863) but as__getitem__
checks for deprecated parameters on each access it might impact performance too much.Improvement after #4726