Skip to content

Add Support for Excluded Regions in Fitting and Visualization #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jul 5, 2025
Merged

Add Support for Excluded Regions in Fitting and Visualization #58

merged 22 commits into from
Jul 5, 2025

Conversation

@AndrewSazonov
Copy link
Member

@AndrewSazonov AndrewSazonov commented Jul 5, 2025

This PR introduces support for defining and handling excluded regions during data analysis.

Key changes include:

  • Implemented logic to exclude specific data points from fitting calculations.
  • Extended Collection with parent handling and on_item_added callback.
  • Improved tutorial notebooks to demonstrate usage of excluded regions.
  • Minor cleanup and formatting improvements throughout related components.

@AndrewSazonov
Very quick and dirty implementation of excluded regions
8199147
@AndrewSazonov
Adds parent handling and item addition callback to Collection
000edc8
@AndrewSazonov
Refactors excluded points handling in diffraction minimization
7264008 
Moves the logic for updating excluded points from minimization to ExcludedRegions, ensuring better modularity.
@AndrewSazonov
Extends unit test with excluded regions
f78efca
@AndrewSazonov
Merge branch 'develop' into excluded-regions
8c2ae12
@AndrewSazonov
Refactors excluded region logic in experiments
966b695 
Optimizes the process of updating the pattern's excluded points
by avoiding unnecessary resets with each new excluded region.

Initializes pattern's excluded points with default values on data load.
@AndrewSazonov
Excludes specified points from calculations for improve accuracy
d85faf5
@AndrewSazonov
Refines excluded region handling in experiments
1dd982d
@AndrewSazonov
Refines data plotting and analysis settings
2125d2d
@AndrewSazonov
Formats function signatures for readability
6f48fe4
@AndrewSazonov
Removes unused assignment in test_fit_with_params
496a10d
@AndrewSazonov
Adds 'excluded' flag to experiment mock data
b158bcf
@AndrewSazonov
Improves handling of excluded data points during minimization
c398ea4
@AndrewSazonov
Enhances exclusion handling in Plotter class
5400e05
@AndrewSazonov
Fixes empty background and excluded regions check
a5d72ff
@AndrewSazonov
Adds CIF display for experiment data
bba7405
@AndrewSazonov
Updates the multiphase tutorial
d709730
@AndrewSazonov
Simplifies exclusion handling in data processing
2eb94d7
@AndrewSazonov
Renames tutorial files and updates documentation
9d52696
@AndrewSazonov
Updates tutorials and adds display for excluded regions
1db57bf
@AndrewSazonov
Refines tutorial markdown headers for consistency
316c972
@AndrewSazonov AndrewSazonov added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] highest Urgent. Needs attention ASAP labels Jul 5, 2025
@AndrewSazonov AndrewSazonov added this to the New API Stabilization milestone Jul 5, 2025
@AndrewSazonov
Adjusts data preprocessing for stability in analysis
5067a3e 
Rounds x-values to 4 decimal places to align data size
Replaces small uncertainty values with 1.0 to prevent
failures in minimization algorithms
@AndrewSazonov AndrewSazonov merged commit c739562 into develop Jul 5, 2025
@AndrewSazonov AndrewSazonov deleted the excluded-regions branch August 6, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

[priority] highest Urgent. Needs attention ASAP [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

New EasyDiffractionLib
Status: Done

Milestone

New API Stabilization

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewSazonov