Skip to content

Commit

Permalink
Switch to es_type
Browse files Browse the repository at this point in the history
  • Loading branch information
mattansb committed Jun 19, 2024
1 parent 23a522e commit ad36239
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: effectsize
Title: Indices of Effect Size
Version: 0.8.8.1
Version: 0.8.8.2
Authors@R:
c(person(given = "Mattan S.",
family = "Ben-Shachar",
Expand Down Expand Up @@ -73,7 +73,7 @@ Depends:
Imports:
bayestestR (>= 0.13.2),
insight (>= 0.19.10),
parameters (>= 0.21.6),
parameters (>= 0.21.7),
performance (>= 0.11.0),
datawizard (>= 0.10.0),
stats,
Expand Down
6 changes: 3 additions & 3 deletions R/eta_squared-main.R
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,7 @@ cohens_f_squared <- function(model,
include_intercept = include_intercept
)

attr(out, "anova_type") <- tryCatch(attr(parameters::model_parameters(model, verbose = FALSE, effects = "fixed", effectsize_type = NULL), "anova_type"),
attr(out, "anova_type") <- tryCatch(attr(parameters::model_parameters(model, verbose = FALSE, effects = "fixed", es_type = NULL), "anova_type"),
error = function(...) 1
)
attr(out, "approximate") <- TRUE
Expand Down Expand Up @@ -864,7 +864,7 @@ cohens_f_squared <- function(model,

# TODO this should be in .anova_es.anvoa
# TODO the aoc method should convert to an anova table, then pass to anova
params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed", effectsize_type = NULL)
params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed", es_type = NULL)
out <- .es_aov_simple(as.data.frame(params),
type = type,
partial = partial, generalized = generalized,
Expand All @@ -890,7 +890,7 @@ cohens_f_squared <- function(model,
verbose = TRUE,
include_intercept = FALSE,
...) {
params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed", effectsize_type = NULL)
params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed", es_type = NULL)
anova_type <- attr(params, "anova_type")
params <- as.data.frame(params)

Expand Down
2 changes: 1 addition & 1 deletion R/eta_squared-methods.R
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@
ci = 0.95, alternative = "greater",
verbose = TRUE,
...) {
params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed", effectsize_type = NULL)
params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed", es_type = NULL)
anova_type <- attr(params, "anova_type")

params <- split(params, factor(params$Response, levels = unique(params$Response))) # make sure row order is not changed
Expand Down

0 comments on commit ad36239

Please sign in to comment.