Fix using a custom rule (#457)

* Fix using a custom rule `ifelse()` is unsafe because it silently only returns the first element of `no` if `test` is of length 1. * Add space before parenthesis --------- Co-authored-by: Brenton M. Wiernik <[email protected]> Co-authored-by: Rémi Thériault <[email protected]>
easystats · Sep 13, 2024 · f2bb5fb · f2bb5fb
1 parent 52903ed
commit f2bb5fb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/R/report_htest_ttest.R b/R/report_htest_ttest.R
@@ -48,7 +48,7 @@
   table <- do.call(effectsize::effectsize, es_args)
   ci <- attributes(table)$ci
   estimate <- names(table)[1]
-  dot_args$rules <- ifelse(is.null(dot_args$rules), rules, dot_args$rules)
+  dot_args$rules <- if (is.null(dot_args$rules)) rules else dot_args$rules
 
   es_args <- c(list(table), dot_args)
   interpretation <- do.call(effectsize::interpret, es_args)$Interpretation