Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new cmdlets. Return null instead of throwing error for GetRegistration #261

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add new cmdlets. Return null instead of throwing error for GetRegistration #261

wants to merge 3 commits into from

Conversation

VitaliHarbiankou
Copy link

Add new cmdlets:

  • Remove-AcmeIdentifier: removes an identifier from vault
  • Revoke-AcmeCertificate: revokes an certificate from Let's Encrypt
  • Remove-AcmeCertificate: removes an certificate from vault and all the related files

Return null instead of throwing error for GetRegistration

@ebekker
Copy link
Owner

ebekker commented Aug 2, 2017

@VitaliHarbiankou , this looks great, thank you for the additions!

Can you add a few unit tests to cover the changes and additions?

@VitaliHarbiankou
Copy link
Author

@ebekker, unfortunately, I can't because I'm not a programmer and didn't write any unit test before. Frankly speaking, it is my first experience with code writing for so long period.

@ebekker ebekker mentioned this pull request Aug 2, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberStrawberry88 CyberStrawberry88 CyberStrawberry88 approved these changes

Assignees

@VitaliHarbiankou VitaliHarbiankou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VitaliHarbiankou @ebekker @CyberStrawberry88