Fix issue of update more than one custom property #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ebess can you merge this pull request please? |
|
@cv-chameleon I really don't remember, how these lines of changes, fix the problem now, but it has worked for me and fixed the problem . you can use this instead if you are in hurry composer require roboticsexpert/advanced-nova-media-library |
|
Thank you @roboticsexpert , in the meantime I already switched to this fork https://github.com/marshmallow-packages/advanced-nova-media-library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as you see request attribute is overriding in first loop iteration and in second iteration it has wrong value that cause to just update first custom property field