implementation for schema namespace definition like SDD #188
Conversation
|
Hey @andrew-svirin, in your commit 1692d4d you implemented the In my opinion, we should move the This wouldn't result in another breaking change, and also doesn't require setting the schema namespace by each user. If you agree with that, I'm happy to change this behaviour as in this comment suggested instead of harmonizing the CCT and CIP builders. Let me know your opinion. |
src/Factories/DocumentFactory.php
Outdated
| @@ -15,7 +15,10 @@ final class DocumentFactory | |||
| public function create(string $content): Document | |||
| { | |||
| $document = new Document(); | |||
| $document->loadXML(utf8_encode($content)); | |||
|
|
|||
| $content = mb_convert_encoding($content, 'UTF-8', mb_list_encodings()); | |||
There was a problem hiding this comment.
mb_convert_encoding($content, 'UTF-8', mb_list_encodings()); I believe this logic can be moved outside library. So into create method should income normalized content. Some description can be added to method.
$document->loadXML($content); should be good.
There was a problem hiding this comment.
I have removed any encodings and updated the method description.
Additionally, I moved the schema attribute for all builders to the end with the current default scheme for better upwards compatibility, as suggested in my pull request description.
|
@linushstge I have little bit updated pull request. Do not know how to add one more commit to current pull request, so created a new one - https://github.com/andrew-svirin/ebics-client-php/pull/189/commits Check it if it that what you intend to add. |
Harmonization of the Document Builder to support custom schema namespaces
Breaking change
$schemaattribute added for CCT and CIP (like in CustomerDirectDebitBuilder.php)This change harmonize all transaction builders to support the schema attribute for all order types as already implemented in SDD
Additional changes