Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull 188 #189

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Pull 188 #189

merged 3 commits into from
Jan 30, 2024

Conversation

andrew-svirin
Copy link
Member

No description provided.

@linushstge
Copy link
Contributor

Thank you very much for your changes. Could we discuss, why this parameter added to as first parameter?

  1. Breaking changes for backwards compatibility
  2. In my opinion, this parameter should be optional and filled with a default

@andrew-svirin
Copy link
Member Author

@linushstge because it's required parameter. it's not too much breaking. This class is not under contract.

@linushstge
Copy link
Contributor

Let's go :)

@andrew-svirin andrew-svirin merged commit 45ff6b6 into 2.x Jan 30, 2024
3 checks passed
@andrew-svirin andrew-svirin deleted the pull-188 branch October 18, 2024 08:20
@andrew-svirin andrew-svirin restored the pull-188 branch October 18, 2024 08:20
@andrew-svirin andrew-svirin deleted the pull-188 branch October 18, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-svirin @linushstge