msvc: implement rbit32 for arm32 #360
Closed
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebiggers
reviewed
Mar 19, 2024
|
I forgot I made a pr already. There is no way to have windows device without rbit. There used to be some, more than 10 years ago. Now even NEON is considered to be present. I just read other comments, I pretty much wrote what's already written there :) |
|
unrelated question. Regarding bsr64/bsf64 for 32-bit builds. These are going to be plain loops, while these should have been implemented in terms of 32-bit _BitScanForward/_BitScanReverse. Ok if I make a pr for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.