Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to introduce a Repo value type #140

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Refactor to introduce a Repo value type #140

merged 7 commits into from
Mar 6, 2024

Conversation

benbc
Copy link
Contributor

@benbc benbc commented Mar 4, 2024

The main purpose here is the refactoring and consequent tidy-up. There are a couple of functional changes along the way which just increase the domain of the security metrics.

This makes it easier to run tests inside an IDE because non-database
tests don't insist on having the database URL provided.
Copy link
Collaborator

@lucyb lucyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice piece of refactoring. It's good to see the lines of code going down and I can see how we can continue improving the code with some of the patterns you've created in this and the previous PR.

Thanks for doing some chores along the way too.

metrics/github/query.py Outdated Show resolved Hide resolved
metrics/timescaledb/db.py Show resolved Hide resolved
tests/metrics/github/test_repos.py Show resolved Hide resolved
@benbc benbc merged commit 17b8629 into main Mar 6, 2024
9 checks passed
@benbc benbc deleted the benbc/github-issues branch March 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants