watermark order is gone, watermark v2 is introduced #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c2e0271
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fe3361bd.signatory.pages.dev |
| Branch Preview URL: | https://379-watermark-order-issue.signatory.pages.dev |
|
Some background information: while the endorsement operation can't obviously be injected before the block it's endorsing it still can be forged and signed before the block header (but not before operations) as it doesn't refer to the final hash of the signed block but to block's payload hash instead which is computed from the operations hash and the block's predecessor hash only. So the signer service shouldn't expect any specific order of block header and endorsement requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the endorsement operation can't obviously be injected before the block it's endorsing it still can be forged and signed before the block header (but not before operations) as it doesn't refer to the final hash of the signed block but to block's payload hash instead which is computed from the operations hash and the block's predecessor hash only. So the signer service shouldn't expect any specific order of block header and endorsement requests.