Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(.goreleaser.yml): change dockerfile name from goreleaser.doc… #469

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GImbrailo
Copy link
Contributor

…kerfile to Dockerfile for standardization and better readability

…kerfile to Dockerfile for standardization and better readability
Copy link
Contributor

@denisandreenko denisandreenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile building an image only for amd64 architecture (for local development, testing on VMs)
For releasing purpose with different architectures - there is goreleaser.dockerfile file.
So there is no need to change this file.

@GImbrailo GImbrailo marked this pull request as draft October 23, 2023 17:14
@GImbrailo
Copy link
Contributor Author

Dockerfile building an image only for amd64 architecture (for local development, testing on VMs) For releasing purpose with different architectures - there is goreleaser.dockerfile file. So there is no need to change this file.

Thanks, @denisandreenko. this PR should have been a draft as I was just starting out. I was hoping we could use the same Dockerfile for our release. If you don't think it is clear cut, I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants