Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added transfer ticket to the wallet API and updated integration tests #3003

Merged
merged 2 commits into from
Jul 17, 2024
Merged

added transfer ticket to the wallet API and updated integration tests #3003

merged 2 commits into from
Jul 17, 2024

Conversation

dsawali
Copy link
Collaborator

@dsawali dsawali commented Jul 3, 2024 •
edited
Loading

closes #2996

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

A new deploy preview is available on Cloudflare Pages at https://baf1d7d4.taquito-test-dapp.pages.dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 3, 2024 •
edited
Loading

Deploying taquito with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2669ff2
Status: ✅  Deploy successful!
Preview URL: https://402e68fa.taquito.pages.dev
Branch Preview URL: https://2996-transfer-ticket-wallet.taquito.pages.dev

View logs

@dsawali dsawali requested review from ac10n and hui-an-yang July 4, 2024 23:24
@dsawali dsawali marked this pull request as ready for review July 4, 2024 23:25
@dsawali dsawali requested a review from ac10n July 16, 2024 19:40
hui-an-yang
hui-an-yang approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@hui-an-yang hui-an-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

hui-an-yang
hui-an-yang reviewed Jul 16, 2024
View reviewed changes
integration-tests/__tests__/wallet/transfer-ticket-operation.spec.ts
const fundSender = await Tezos.contract.transfer({ to: senderPkh, amount: 5 });
await fundSender.confirmation();

const ticketSendOrigination = await Tezos.contract.originate({ code: ticketsSendTz, storage: null });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing ticketsSendTz originated here the 2nd time made me want to originate it at integration-tests/originate-known-contracts.ts as knownTicketContract. And integration-tests/__tests__/rpc/nodes.spec.ts can benefit from this too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not a bad idea, we can make a ticket for that.

@dsawali dsawali merged commit 6d0715c into master Jul 17, 2024
8 of 9 checks passed
@dsawali dsawali deleted the 2996-transfer-ticket-wallet branch July 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hui-an-yang hui-an-yang hui-an-yang approved these changes

@ac10n ac10n Awaiting requested review from ac10n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the transferTicket operation in the wallet API
3 participants
@dsawali @ac10n @hui-an-yang