Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: beacon-wallet open handles in tests #3015

Merged

Conversation

IsaccoSordo
Copy link

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

Hi all,

After extensive investigation, it appears that the issue lies not with the broadcast-channel module itself, but with the base BroadcastChannel module, as using the latter also results in the same problems.

Additionally, for some reason, Jest is detecting a timeout inside PostMessageTransport as an open handle.

To address this, I have mocked the entire class and used fake timers to ensure handles are freed promptly.

Thank you in advance for the time you will dedicate to reviewing my PR.

@IsaccoSordo IsaccoSordo changed the title fix: test fix: beacon-wallet open handles in tests Jul 25, 2024
@ac10n
Copy link
Contributor

ac10n commented Jul 25, 2024

Hello @IsaccoSordo,

Thanks for your contribution.

For the timeout part, we have added a --openHandlesTimeout=5000 flag to jest. That waits long enough (just more than one second is enough) to let this timeout resolve.

@dsawali dsawali merged commit 85ea602 into ecadlabs:beacon-4.3.0-beta.0 Jul 25, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants