Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v9 #5155

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 9, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) 8.57.0 -> 9.9.1 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.9.1

Compare Source

v9.9.0

Compare Source

Features

  • 41d0206 feat: Add support for TS config files (#​18134) (Arya Emami)
  • 3a4eaf9 feat: add suggestion to require-await to remove async keyword (#​18716) (Dave)

Documentation

  • 9fe068c docs: how to author plugins with configs that extend other configs (#​18753) (Alec Gibson)
  • 48117b2 docs: add version support page in the side navbar (#​18738) (Amaresh S M)
  • fec2951 docs: add version support page to the dropdown (#​18730) (Amaresh S M)
  • 38a0661 docs: Fix typo (#​18735) (Zaina Al Habash)
  • 3c32a9e docs: Update yarn command for creating ESLint config (#​18739) (Temitope Ogunleye)
  • f9ac978 docs: Update README (GitHub Actions Bot)

Chores

v9.8.0

Compare Source

v9.7.0

Compare Source

Features

  • 7bd9839 feat: add support for es2025 duplicate named capturing groups (#​18630) (Yosuke Ota)
  • 1381394 feat: add regex option in no-restricted-imports (#​18622) (Nitin Kumar)

Bug Fixes

  • 14e9f81 fix: destructuring in catch clause in no-unused-vars (#​18636) (Francesco Trotta)

Documentation

  • 9f416db docs: Add Powered by Algolia label to the search. (#​18633) (Amaresh S M)
  • c8d26cb docs: Open JS Foundation -> OpenJS Foundation (#​18649) (Milos Djermanovic)
  • 6e79ac7 docs: loadESLint does not support option cwd (#​18641) (Francesco Trotta)

Chores

v9.6.0

Compare Source

v9.5.0

Compare Source

v9.4.0

Compare Source

v9.3.0

Compare Source

v9.2.0

Compare Source

v9.1.1

Compare Source

v9.1.0

Compare Source

v9.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the renovate label May 9, 2024
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch 3 times, most recently from 3a1b29e to 5508923 Compare May 17, 2024 23:42
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch 3 times, most recently from 123acb4 to a86a8e7 Compare May 22, 2024 15:28
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch 4 times, most recently from 306879b to ffb0004 Compare June 1, 2024 00:38
@usu
Copy link
Member

usu commented Jun 2, 2024

Eslint 9 uses a new configuration format by default (called "flat configuration"). So this PR would need some config changes before we can upgrade to eslint9.

For Nuxt, some further details are described here:
https://eslint.nuxt.com/guide/faq#package-disambiguation
https://eslint.nuxt.com/packages/module

And here is a eslint migration guide for the new config format:
https://eslint.org/docs/latest/use/configure/migration-guide

@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch from ffb0004 to 48cae1c Compare June 2, 2024 10:54
@BacLuc
Copy link
Contributor

BacLuc commented Jun 2, 2024

Eslint 9 uses a new configuration format by default (called "flat configuration"). So this PR would need some config changes before we can upgrade to eslint9.

For Nuxt, some further details are described here: https://eslint.nuxt.com/guide/faq#package-disambiguation https://eslint.nuxt.com/packages/module

And here is a eslint migration guide for the new config format: https://eslint.org/docs/latest/use/configure/migration-guide

also stumbled on this yesterday.

@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch from 48cae1c to 9212e17 Compare June 2, 2024 11:33
@BacLuc
Copy link
Contributor

BacLuc commented Jun 2, 2024

@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch 4 times, most recently from 77b9c6e to 0ab1647 Compare June 7, 2024 18:54
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch 8 times, most recently from d19ca77 to f4e186c Compare June 19, 2024 23:17
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch from f4e186c to a55c162 Compare June 26, 2024 23:16
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch 4 times, most recently from 8218f3d to 6edf7bc Compare August 23, 2024 21:39
BacLuc added a commit to BacLuc/ecamp3 that referenced this pull request Aug 24, 2024
It seems unused in our configuration,
and i tested it by throwing an error
in the index.js script.
(And our imports don't seem to follow a structure).
When import-js/eslint-plugin-import#2948
is resolved, we can think about adding it again.
Allows ecamp#5155 for the frontend.
BacLuc added a commit to BacLuc/ecamp3 that referenced this pull request Aug 24, 2024
It seems unused in our configuration.
When import-js/eslint-plugin-import#2948
is resolved, we can think about adding it again.
Allows ecamp#5155 for aws-setup.
@renovate renovate bot changed the title chore(deps): update dependency eslint to v9 Update dependency eslint to v9 Aug 27, 2024
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch from 6edf7bc to b17234c Compare August 27, 2024 18:32
@renovate renovate bot changed the title Update dependency eslint to v9 chore(deps): update dependency eslint to v9 Aug 27, 2024
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch 4 times, most recently from 90eacdb to d2bc430 Compare August 28, 2024 20:42
Copy link
Contributor Author

renovate bot commented Aug 28, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@BacLuc BacLuc requested a review from a team August 28, 2024 20:47
@BacLuc BacLuc requested a review from a team September 12, 2024 20:13
@BacLuc BacLuc force-pushed the renovate/major-eslint-monorepo branch from 82c9d77 to 2489ccb Compare September 12, 2024 20:26
// eslint-disable-next-line no-constant-condition

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this rule dropped?

Copy link
Contributor

@BacLuc BacLuc Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know, maybe it is more sophisticated and detects the if statement in the loop.

@BacLuc BacLuc added this pull request to the merge queue Sep 12, 2024
Merged via the queue into devel with commit edc1491 Sep 12, 2024
54 checks passed
@BacLuc BacLuc deleted the renovate/major-eslint-monorepo branch September 12, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants