Fix a bug where sendNotifications could crash and prevent precompress…

…ion from occuring. Also added try catch into sendNotifications to try and prevent crashes

server/sendnotifications.js

@@ -46,37 +46,42 @@ function sendNotifications(ignoreNoneUntil = false) {
             }
 
 			for (let prop in rivers) {
-				let river = rivers[prop]
-
-                let flow;
-                for (let i=readings.length - 1;i>=0;i--) {
-                    //Find the latest non-forecast flow value.
-                    if (readings[i].forecast !== true) {
-                        flow = readings[i];
-                        break;
+                try {
+                    let river = rivers[prop]
+
+                    let flow;
+                    for (let i=readings.length - 1;i>=0;i--) {
+                        //Find the latest non-forecast flow value.
+                        if (readings[i].forecast !== true) {
+                            flow = readings[i];
+                            break;
+                        }
                     }
-                }
 
-                let units = river.units
+                    let units = river.units
 
-                let meterInFeet = 3.2808399
-                let cubicMeterInFeet = meterInFeet**3
+                    let meterInFeet = 3.2808399
+                    let cubicMeterInFeet = meterInFeet**3
 
-				if (river.units === "cms") {river.current = flow.cfs / cubicMeterInFeet}
-				if (river.units === "meters") {river.current = flow.feet / meterInFeet}
-                else {river.current = flow[units]}
+                    if (river.units === "cms") {river.current = flow.cfs / cubicMeterInFeet}
+                    if (river.units === "meters") {river.current = flow.feet / meterInFeet}
+                    else {river.current = flow[units]}
 
-				//Don't delete for email notifications
-				if (!(river.minimum < river.current && river.current < river.maximum)) {
-					if (user.type === "email") {
-						rivers[prop].running = false //For email only, add the river even if it is not running.
-						data[prop] = rivers[prop]
-					}
-				}
-				else {
-					data[prop] = rivers[prop] //Add the river if it is running
-					data[prop].running = true
-				}
+                    //Don't delete for email notifications
+                    if (!(river.minimum < river.current && river.current < river.maximum)) {
+                        if (user.type === "email") {
+                            rivers[prop].running = false //For email only, add the river even if it is not running.
+                            data[prop] = rivers[prop]
+                        }
+                    }
+                    else {
+                        data[prop] = rivers[prop] //Add the river if it is running
+                        data[prop].running = true
+                    }
+                }
+                catch(e) {
+                    console.error(e)
+                }
 			}
 		}
 

server/usgscache.js

@@ -106,7 +106,13 @@ async function updateCachedData() {
 		process.exit()
 	}
 
-	sendNotifications()
+	try {
+		sendNotifications()
+	}
+	catch (e) {
+		console.log("ERROR: sendNotifications errored")
+		console.log(error)
+	}
 
 	console.log("Precompressing files...")
 	compressor.compressFiles(utils.getSiteRoot())