-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User header mobile, Transaction operations, Language switcing #89
Conversation
src/common/api/urls.tsx
Outdated
@@ -4,6 +4,7 @@ import { ConfigItems } from "../../../config"; | |||
// Get witness Account | |||
export const getAccount = async (user: string) => { | |||
const account_url = `${ConfigItems.baseUrl}/api/get_accounts?names=["${user}"]`; | |||
console.log(account_url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear all console logs @ahmedaftab-RT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Console logs have been removed
import UserAvatar from "../user-avatar"; | ||
import { LinkAccount } from "../../pages/fields/common_fields"; | ||
import parseAsset from "../../helper/parse-asset"; | ||
import { Card, Col, Row } from "react-bootstrap"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move package imports at top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@@ -0,0 +1,178 @@ | |||
import React, { useState, useEffect } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
component file names should start with lowercase always to keep consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
</h3> | ||
<h6 className="text-capitalize">ID: {id}</h6> | ||
{metaProfile.about && ( | ||
<h6 className="text-capitalize">About: {metaProfile.about}</h6> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all text should be added into translation string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in the translation files
@@ -5,21 +5,21 @@ | |||
}, | |||
"nav": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't edit other language files, only en-US.json. If you want to modify some strings, do them in crowdin.com, ask for invite so I can add you there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited some of the keys with their respective language translation to test the localization working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited some of the keys with their respective language translation to test the localization working
@ahmedaftab-RT Only do that from crowdin.com website so we get update from that service on separate PR.
src/common/pages/header/index.tsx
Outdated
@@ -10,6 +10,9 @@ import { brightnessSvg, hiveLogo, globeImg } from "../../img/svg"; | |||
import { languages } from "../../languages"; | |||
import { toggleTheme } from "../../store/global/index"; | |||
import { _t } from "../../i18n"; | |||
import * as ls from "../../util/local-storage"; | |||
import i18n from "i18next"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move package imports to top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@@ -102,6 +107,7 @@ const TransactionOperationTable = (props: any) => { | |||
<tbody> | |||
{Object.keys(opVal).map((key, k: number) => { | |||
k = k + Math.floor(Math.random() * 10000) + 9000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use randomness for keys, use unique values from array/object in equation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the random keys with random numbers have been resolved
src/common/routes.ts
Outdated
@@ -3,7 +3,7 @@ export default { | |||
ABOUT:'/about', | |||
Contact:'/contact', | |||
Service:'/service', | |||
HeadBlock:'/head/b/:id', | |||
HeadBlock:'/head/b/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmedaftab-RT why headblock route has changed?
#87 Language Selectors
Known Issue:
Language switching changes appearing after the refresh
#86 Transactions Operations Cards
#90 User Pofile Header Mobile view #90