Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename release branch to next #18

Closed
cball opened this issue Oct 31, 2019 · 5 comments
Closed

rename release branch to next #18

cball opened this issue Oct 31, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@cball
Copy link
Member

cball commented Oct 31, 2019

I feel like the name release is a little bit confusing, especially as a target branch. If we keep the approach where merging to master creates the release I think it might make more sense to name the default branch next. This way next would contain everything that will be in the next version.

Same concept different name. Thoughts?

@cball cball added the question Further information is requested label Oct 31, 2019
@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 31, 2019

Makes sense to me!

Whoever you want to do this (you or me), will you assign that issue to that person?

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 31, 2019

We'll need to:

  • create new branch next from release
  • update open PRs to merge into next
  • change default branch in Settings
  • update CONTRIBUTING
  • update branch protection settings
  • update PR template to remind people to point to next

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 4, 2019

I say once we get #24 and #26 merged in, let's tackle this.

@jsjoeio jsjoeio added chore and removed question Further information is requested labels Nov 4, 2019
@jsjoeio jsjoeio added this to the v1.1.0 milestone Nov 5, 2019
@jsjoeio jsjoeio added blocked and removed blocked labels Nov 6, 2019
@jsjoeio jsjoeio self-assigned this Nov 7, 2019
@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 7, 2019

Now that I'm thinking about how others do it, I think this makes most sense:

  • change release to next
  • make master the default. this way, users see it when they come to the repo and then the README and everything will be in sync with what they see on npm
  • when we create a new release, we merge next into master

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 7, 2019

Done via 773d8f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants