feat(generate, init): create new release #39

jsjoeio · 2019-11-11T18:24:06Z

This PR merges all the work from the milestone for v1.1.0. Since this has several new changes and is not backwards compatible, it should be released as a new MAJOR release. This should happen automatically because we mention the words "BREAKING CHANGE".

Changes

see commits and milestone

BREAKING CHANGE: The commands between v1.0.0 and this version are no longer compatible. We changed a few flags and used args instead. Please see the docs for the latest changes.

Screenshots

N/A

Checklist

* feat: update README and add CONTRIBUTING * fix: update generate command args * feat: update docs with new generate command info

* docs: update README.md * docs: create .all-contributorsrc

* feat: add semantic-release/git * feat: add npm plugin as well

* Update issue templates Add a simple issue report template * Create pull_request_template.md add PR template

* docs: update README.md * docs: update .all-contributorsrc

It makes more sense to call this bug because it's a bug report issue template

add feature request template

Remove stuff specific to Gatsby

* feat: add init command * feat: add node types * feat: add write to package.json in init * refactor: write to package.json * feat: add install eb-scripts line * refactor: change name of vars * chore: update oclif.manifest and README * Update src/commands/init.ts Co-Authored-By: Chris Ball <[email protected]> * fix: modify order of updatedScripts

* docs: update README.md * docs: update .all-contributorsrc

* first commit * moar progress * passing tests * reorg deps * cast as any properly * updating per review * move jest config into package.json * feat: update circleci config

* docs: update README.md * docs: update .all-contributorsrc

* feat: add prettier and husky * chore: add eslint and deps * chore: add eslint plugins prettier and eb

* fix: add back in semantic release plugins * fix: add jest config and install fs-extra * feat: add makeTempDir and removeTempDir utils * wip: add initial generate test * feat: add util fn to check if dir exists * refactor: change names temp dir fns * refactor: add index to simplify exports * wip: add test with oclif * feat: add checkFileExists util * chore: update deps * chore: add checkFileExists to index * wip: almost there * wip: generate test * feat: add test for no flags * wip: add oclif test * feat: write snapshot test for generate error * chore: clean up deps * wip: add test to check custom templates * feat: add test to check using custom templates * refactor: use copyFile instead of writeFile * feat: update snapshot and get test passing default * refactor: create tests/helpers and move template * chore: update order of types in package.json * refactor: remove proxy fse fns * refactor: clean up getTemplateLocation

* docs: update README.md * docs: update .all-contributorsrc

* feat: add commit analyzer and rel not generator semantic release * fix: only release if semantic-release passes * refactor: use npm ci in circleci * refactor: use yarn in circleci config * fix: typo in release section * fix: switch back to npm in config * fix: change back to npm install

* fix: add back in semantic release plugins * fix: add jest config and install fs-extra * feat: add makeTempDir and removeTempDir utils * feat: add util fn to check if dir exists * refactor: change names temp dir fns * wip: add test with oclif * feat: add checkFileExists util * wip: almost there * wip: generate test * feat: add test for no flags * wip: add oclif test * feat: write snapshot test for generate error * chore: clean up deps * wip: add test to check custom templates * feat: add test to check using custom templates * refactor: use copyFile instead of writeFile * refactor: create tests/helpers and move template * chore: update order of types in package.json * refactor: remove proxy fse fns * feat: add initial init test * wip: get tests setup for init * feat: finish yarn lock * feat: add test for init without flag * feat: add validProjectTypes to init, and test * fix: run tests sequentially with --runInBand * refactor: clean up unused tests init * fix: update README formatting * fix: update getTemplateLocation test * refactor: fix getTemplateLocation test * refactor: move afterEach and afterAll into describe block * fix: switch to yarn * fix: update test description * docs: add comment about dup import of fn * fix: update test description in init.test * refactor: use flag or args for init, remove -p * chore: update README * wip: update init and test to make project required * fix: tell jest to ignore lib * fix: update init tests and snap * feat: add path flag to generate and update temps * fix: update generate to throw on no args * fix: remove extra space in templates * fix: update test description * fix: update log statement in generate * fix: remove other extra space * fix: update old test * fix: update helper template for test * feat: add test for location flag * fix: unskip tests * refactor: remove side effect in last test * feat: add -p to script in init * refactor: unskip and use all tests * fix: update test after rebase * fix: update snapshot after rebase not updating it * feat: add react-typescript-component templates * refactor: improve typings in generate command * refactor: remove old template flag from generate * wip: add test for react-typescript-component * feat: add react-typescript-component as new temp type * fix: typos in react-ts-component template * fix: remove old copyFile fn * feat: add react-typescript to init projects * feat: update snapshots and add test * refactor: require to readFile to prevent caching * fix: remove console.logs * docs: update with new command info * fix: update item in checklist for PR * fix: update circle ci config * fix: switch back to yarn

* fix: add back in semantic release plugins * fix: add jest config and install fs-extra * feat: add makeTempDir and removeTempDir utils * feat: add util fn to check if dir exists * refactor: change names temp dir fns * wip: add test with oclif * feat: add checkFileExists util * wip: almost there * wip: generate test * feat: add test for no flags * wip: add oclif test * feat: write snapshot test for generate error * chore: clean up deps * wip: add test to check custom templates * feat: add test to check using custom templates * refactor: use copyFile instead of writeFile * refactor: create tests/helpers and move template * chore: update order of types in package.json * refactor: remove proxy fse fns * fix: run tests sequentially with --runInBand * fix: update getTemplateLocation test * refactor: fix getTemplateLocation test * chore: update README * fix: update init tests and snap * fix: update generate to throw on no args * fix: update test description * fix: update old test * refactor: remove side effect in last test * feat: add -p to script in init * refactor: unskip and use all tests * fix: update test after rebase * fix: update snapshot after rebase not updating it * fix: errors after rebase * fix: update snapshot

* feat: add component template * refactor: change name to react-native-typescript * refactor: change name to typescript component * feat: add react-typescript-component to generate * feat: add test for react-native-typescript-component * feat: add react-native-typescript to init * feat: add react-native-typescript screen template * feat: add react-native-typescript-screen to generate * wip: generate screen test * wip: add note about screen template test * feat: add e2e template * feat: add e2e to init command * feat: add e2e to generate * fix: update quotes to double in e2e template * feat: add e2e to react-native-ts and add tset * feat: add e2e template test * fix: update snapshot after changes * feat: add util-typescript-template * feat: add util-typescript to generate and init * fix: add test and default path for utils temp * fix: update generate test * fix: update generate snapshot after new util template * fix: update docs * fix: clean up from comments * fix: comment out skipped test * fix: change component name in test

cball

Looking great @jsjoeio!

.github/ISSUE_TEMPLATE/bug_ report.md

cball · 2019-11-11T18:28:46Z

.github/pull_request_template.md

+
+## Checklist
+
+- [ ] your PR is pointed at `next` (unless it's a new release)


is this necessary? if this is our default branch I don't see anyone changing it. For new releases, I don't think we need to require a PR... it should probably just merge next -> master.

I would argue yes. master is the default. New work goes into next. This way, if anyone goes to the project, they see master which is the code equivalent to our latest package release. Here's the comment where I proposed that: #18 (comment)

I don't think we need to require a PR... it should probably just merge next -> master

Hmm...I disagree here - I think the PR allows for an extra set of eyes. But if you don't, then we can skip that.

This way, if anyone goes to the project, they see master

I'd argue that it's very often the case that in traditional OSS flow, master is the "yet to be released" work and it's fairly common to not have master be ahead of the released version.

Hmm...I disagree here - I think the PR allows for an extra set of eyes. But if you don't, then we can skip that.

The reason I don't think this is required is we review every PR that goes in. The merge / release step should be automated via tooling, so there should not be additional code that is added manually.

Ah, I see what you're saying. Okay well by default semnatic-release creates a new release when we merge into master. I set it up the way it is now, to avoid releasing every time we merge to master.

So the new question is, how do you want to set it up so we PR into master and create a new trigger to generate a release?

.github/pull_request_template.md

README.md

package.json

* feat: update README and add CONTRIBUTING * fix: update generate command args * feat: update docs with new generate command info

* Update issue templates Add a simple issue report template * Create pull_request_template.md add PR template

* feat: add init command * feat: add node types * feat: add write to package.json in init * refactor: write to package.json * feat: add install eb-scripts line * refactor: change name of vars * chore: update oclif.manifest and README * Update src/commands/init.ts Co-Authored-By: Chris Ball <[email protected]> * fix: modify order of updatedScripts

* fix: add back in semantic release plugins * fix: add jest config and install fs-extra * feat: add makeTempDir and removeTempDir utils * feat: add util fn to check if dir exists * refactor: change names temp dir fns * wip: add test with oclif * feat: add checkFileExists util * wip: almost there * wip: generate test * feat: add test for no flags * wip: add oclif test * feat: write snapshot test for generate error * chore: clean up deps * wip: add test to check custom templates * feat: add test to check using custom templates * refactor: use copyFile instead of writeFile * refactor: create tests/helpers and move template * chore: update order of types in package.json * refactor: remove proxy fse fns * feat: add initial init test * wip: get tests setup for init * feat: finish yarn lock * feat: add test for init without flag * feat: add validProjectTypes to init, and test * fix: run tests sequentially with --runInBand * refactor: clean up unused tests init * fix: update README formatting * fix: update getTemplateLocation test * refactor: fix getTemplateLocation test * refactor: move afterEach and afterAll into describe block * fix: switch to yarn * fix: update test description * docs: add comment about dup import of fn * fix: update test description in init.test * refactor: use flag or args for init, remove -p * chore: update README * wip: update init and test to make project required * fix: tell jest to ignore lib * fix: update init tests and snap * feat: add path flag to generate and update temps * fix: update generate to throw on no args * fix: remove extra space in templates * fix: update test description * fix: update log statement in generate * fix: remove other extra space * fix: update old test * fix: update helper template for test * feat: add test for location flag * fix: unskip tests * refactor: remove side effect in last test * feat: add -p to script in init * refactor: unskip and use all tests * fix: update test after rebase * fix: update snapshot after rebase not updating it * feat: add react-typescript-component templates * refactor: improve typings in generate command * refactor: remove old template flag from generate * wip: add test for react-typescript-component * feat: add react-typescript-component as new temp type * fix: typos in react-ts-component template * fix: remove old copyFile fn * feat: add react-typescript to init projects * feat: update snapshots and add test * refactor: require to readFile to prevent caching * fix: remove console.logs * docs: update with new command info * fix: update item in checklist for PR * fix: update circle ci config * fix: switch back to yarn

* fix: add back in semantic release plugins * fix: add jest config and install fs-extra * feat: add makeTempDir and removeTempDir utils * feat: add util fn to check if dir exists * refactor: change names temp dir fns * wip: add test with oclif * feat: add checkFileExists util * wip: almost there * wip: generate test * feat: add test for no flags * wip: add oclif test * feat: write snapshot test for generate error * chore: clean up deps * wip: add test to check custom templates * feat: add test to check using custom templates * refactor: use copyFile instead of writeFile * refactor: create tests/helpers and move template * chore: update order of types in package.json * refactor: remove proxy fse fns * fix: run tests sequentially with --runInBand * fix: update getTemplateLocation test * refactor: fix getTemplateLocation test * chore: update README * fix: update init tests and snap * fix: update generate to throw on no args * fix: update test description * fix: update old test * refactor: remove side effect in last test * feat: add -p to script in init * refactor: unskip and use all tests * fix: update test after rebase * fix: update snapshot after rebase not updating it * fix: errors after rebase * fix: update snapshot

* feat: add component template * refactor: change name to react-native-typescript * refactor: change name to typescript component * feat: add react-typescript-component to generate * feat: add test for react-native-typescript-component * feat: add react-native-typescript to init * feat: add react-native-typescript screen template * feat: add react-native-typescript-screen to generate * wip: generate screen test * wip: add note about screen template test * feat: add e2e template * feat: add e2e to init command * feat: add e2e to generate * fix: update quotes to double in e2e template * feat: add e2e to react-native-ts and add tset * feat: add e2e template test * fix: update snapshot after changes * feat: add util-typescript-template * feat: add util-typescript to generate and init * fix: add test and default path for utils temp * fix: update generate test * fix: update generate snapshot after new util template * fix: update docs * fix: clean up from comments * fix: comment out skipped test * fix: change component name in test

cball

A few more thoughts

src/utils/index.ts

cball · 2019-11-11T19:48:21Z

src/_templates/react-native-typescript-screen/new/prompt.js

+    choices: ["FC", "Class"],
+    default: "FC"
+  }
+];


I think we can remove this to try and enforce functional components

Ryan said yes. I don't have enough RN exp to say no.

cball · 2019-11-11T19:48:59Z

src/_templates/react-native-typescript-screen/new/component.ejs

+to: <%= root %>/<%= path %>/<%= h.inflection.transform(name, ['undasherize', 'classify']) %>/<%= h.inflection.transform(name, ['undasherize', 'classify']) %>.tsx
+---
+<% const comp = h.inflection.transform(name, ['undasherize', 'classify']) -%>
+<% if(componentType === 'Class') { -%>


Do we need to keep class components?

will discuss as a group later.

# [2.0.0](v1.0.0...v2.0.0) (2019-11-11) ### Features * **generate, init:** create new release ([#39](#39)) ([c4d4f54](c4d4f54)), closes [#6](#6) [#13](#13) [#14](#14) [#15](#15) [#16](#16) [#11](#11) [#22](#22) [#8](#8) [#23](#23) [#26](#26) [#24](#24) [#35](#35) [#30](#30) [#36](#36) [#33](#33) [#37](#37) [#6](#6) [#15](#15) [#11](#11) [#36](#36) [#33](#33) [#37](#37) ### BREAKING CHANGES * **generate, init:** modify how generate command works

JavaScript Joe and others added 23 commits October 30, 2019 13:40

docs(contrib): add ci and update generate command docs (#6)

a0721cf

* feat: update README and add CONTRIBUTING * fix: update generate command args * feat: update docs with new generate command info

docs: add jsjoeio as a contributor (#13)

1c79562

* docs: update README.md * docs: create .all-contributorsrc

chore: add @semantic-release/npm & .../git plugins (#14)

af5f602

* feat: add semantic-release/git * feat: add npm plugin as well

chore(templates): add issue template (#15)

e63ba90

* Update issue templates Add a simple issue report template * Create pull_request_template.md add PR template

docs: add cmejet as a contributor (#16)

846208a

* docs: update README.md * docs: update .all-contributorsrc

change name to bug instead of issue

f3d7f93

It makes more sense to call this bug because it's a bug report issue template

Create feature_request.md

1e32b9c

add feature request template

Update and rename issue-report.md to bug_ report.md

3f0701a

chore: clean up template

417b5bd

Remove stuff specific to Gatsby

docs: add alvincrespo as a contributor (#22)

599b578

* docs: update README.md * docs: update .all-contributorsrc

feat(tests): adds basic testing support (#8)

5719cfd

* first commit * moar progress * passing tests * reorg deps * cast as any properly * updating per review * move jest config into package.json * feat: update circleci config

docs: add cball as a contributor (#23)

c06ef34

* docs: update README.md * docs: update .all-contributorsrc

chore(project): add prettier, eslint and husky (#26)

ad3d0fd

* feat: add prettier and husky * chore: add eslint and deps * chore: add eslint plugins prettier and eb

docs: add jeffreyzhen as a contributor (#35)

537e0e0

* docs: update README.md * docs: update .all-contributorsrc

refactor: update CONTRIBUTING PR process

d05d009

refactor: update PR template to add check for base branch

773d8f9

fix: update version to match npm version

c2aebbc

jsjoeio requested a review from a team November 11, 2019 18:24

jsjoeio self-assigned this Nov 11, 2019

JavaScript Joe and others added 2 commits November 11, 2019 11:26

Merge branch 'master' into next

cf3fccd

fix: update oclif manifest to match master

6ae3b68

cball requested changes Nov 11, 2019

View reviewed changes

jsjoeio added 2 commits November 11, 2019 11:42

fix: update PR template

36d316c

fix: update bug report

8fb932a

jsjoeio and others added 10 commits November 11, 2019 12:07

[ci skip]: fix version issue

e2296e5

docs(contrib): add ci and update generate command docs (#6)

04fcbc4

* feat: update README and add CONTRIBUTING * fix: update generate command args * feat: update docs with new generate command info

chore(templates): add issue template (#15)

fc04f05

* Update issue templates Add a simple issue report template * Create pull_request_template.md add PR template

Update and rename issue-report.md to bug_ report.md

d08a635

fix: remove flag from yarn test

3104e8f

Merge branch 'master' into next

774f998

jsjoeio requested a review from cball November 11, 2019 19:29

jsjoeio added 3 commits November 11, 2019 12:31

fix: update snapshots

cd6c8f2

fix: updte bin run

6cced3e

fix: update oclif and init snapshot

1f71aaf

cball requested changes Nov 11, 2019

View reviewed changes

jsjoeio added 4 commits November 11, 2019 13:13

reactor: export all utils

cdb9b35

refactor: move test higher

9b2421a

fix: update snapshots and add runInBand flag to yarn test

e9974d3

fix: update PR template to remove check for next branch

f77b4a0

cball approved these changes Nov 11, 2019

View reviewed changes

jsjoeio merged commit c4d4f54 into master Nov 11, 2019

jsjoeio deleted the next branch November 11, 2019 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(generate, init): create new release #39

feat(generate, init): create new release #39

jsjoeio commented Nov 11, 2019

cball left a comment

cball Nov 11, 2019

jsjoeio Nov 11, 2019 •

edited

Loading

cball Nov 11, 2019 •

edited

Loading

jsjoeio Nov 11, 2019

cball left a comment

cball Nov 11, 2019

jsjoeio Nov 11, 2019

cball Nov 11, 2019

jsjoeio Nov 11, 2019

cball Nov 11, 2019


		## Checklist

		- [ ] your PR is pointed at `next` (unless it's a new release)

feat(generate, init): create new release #39

feat(generate, init): create new release #39

Conversation

jsjoeio commented Nov 11, 2019

Changes

Screenshots

Checklist

cball left a comment

Choose a reason for hiding this comment

cball Nov 11, 2019

Choose a reason for hiding this comment

jsjoeio Nov 11, 2019 • edited Loading

Choose a reason for hiding this comment

cball Nov 11, 2019 • edited Loading

Choose a reason for hiding this comment

jsjoeio Nov 11, 2019

Choose a reason for hiding this comment

cball left a comment

Choose a reason for hiding this comment

cball Nov 11, 2019

Choose a reason for hiding this comment

jsjoeio Nov 11, 2019

Choose a reason for hiding this comment

cball Nov 11, 2019

Choose a reason for hiding this comment

jsjoeio Nov 11, 2019

Choose a reason for hiding this comment

cball Nov 11, 2019

Choose a reason for hiding this comment

jsjoeio Nov 11, 2019 •

edited

Loading

cball Nov 11, 2019 •

edited

Loading