Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I should be able to install echobind's eslint rules in my project #25

Open
2 tasks
alvincrespo opened this issue Nov 4, 2019 · 6 comments
Labels
enhancement New feature or request needs discussion

Comments

@alvincrespo
Copy link

Summary

eb-scripts init --linting

By default, this would include our eslint configuration into a project.

Motivation

Why are we doing this?

To give developers an easy method to setup eslint on their project.

What use cases does it support?

Initializing a new project that enforces consistency.

What is the expected outcome?

  • Adds eslint configuration to their package.json
  • Adds dependencies to their package.json
@alvincrespo alvincrespo added enhancement New feature or request needs discussion labels Nov 4, 2019
@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 4, 2019

What if instead, we packaged our linting inside eb-scripts? You wouldn't have to do anything at all.

@alvincrespo
Copy link
Author

Since it's our scripts we can do that and be opinionated - but it comes down to whether we see others wanting that to be installed on their project.

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 4, 2019

Well, this is intended for us. People wanting to use it would be a side effect (IMO).

We might be able to leverage a similar pattern as the /_templates feature.

  1. Include our own implementation of eslint in eb-scripts
  2. If a user wants to override, they can add the same file to their root

Thoughts?

@jsjoeio jsjoeio added this to the v1.1.0 milestone Nov 5, 2019
@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 6, 2019

I was thinking about it...

I think your original idea makes the most sense.

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 6, 2019

We would also need a value to know which linting to add (React, Node or React Native)

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 7, 2019

Another thought that came to mind, you should be able to do this in two ways:

  • eb-scripts init --linting <react | react-native | node>
  • eb-scripts add --linting <react | react-native | node>

In the first scenario, you're initialing a project and you want to include linting in the process. In the second scenario, you already have a project and want to add the linting.

@jsjoeio jsjoeio removed this from the v1.1.0 milestone Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs discussion
Projects
None yet
Development

No branches or pull requests

2 participants