Revamped contract for escrow #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/EchoCrossChain.sol # src/EchoState.sol
Started working on redeeming expired offers
|
Coverage after merging feature/escrow into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging feature/escrow into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+64
to
+66
| function _consumeMessage(bytes32 hash) internal { | ||
| _state.consumedMessages[hash] = true; | ||
| } |
Check warning
Code scanning / Slither
Dead-code Warning
Comment on lines
+68
to
+70
| function _verifyEmitter(IWormhole.VM memory vm) internal view returns (bool) { | ||
| return _state.registeredEmitters[vm.emitterChainId] == vm.emitterAddress; | ||
| } |
Check warning
Code scanning / Slither
Dead-code Warning
|
Coverage after merging feature/escrow into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging feature/escrow into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging feature/escrow into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
src/Echo.sol
Outdated
| event OfferExecuted(bytes32 indexed offerId); | ||
| // @dev For future use... | ||
|
|
||
| uint16 private immutable CHAIN_ID; |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
Publishing on blast now works Added a few more scripts Fixed the chain id bug
0xjohnnycagewins
approved these changes
Jul 15, 2024
| assertOfferItemsEq(offer1.receiverItems, offer2.receiverItems); | ||
| assertEq(uint256(offer1.state), uint256(offer2.state)); | ||
| assertEq(offer1.expiration, offer2.expiration); | ||
| } |
There was a problem hiding this comment.
following my comments on the first PR, I'd add an "assertOfferState` function
Added blast specific data on contract
|
Coverage after merging feature/escrow into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Comment on lines
+17
to
+19
| function claimGas() external onlyOwner { | ||
| BLAST.claimMaxGas(address(this), msg.sender); | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.