Fixing an issue with UUID to JSON serialization #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount permissions to the collections.
|
Hi @erwin-eiq, Could you please check out my PR? There is also very similar PR #240 |
|
@eric-eclecticiq Is there any chance you can take a look at this? This PR and other like it have been hanging out for over 2 years and fix crucial issue in there TAXII 2 implementation. It seems like you're the newest guy with write access to the repo and nobody else is looking at PRs. |
|
Yes, I can have a look. Could you please add a test for each point ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #243 (covers #251 as well)
--adminflag