Add ASSEMBLE_XX_FROM_BOOLS fct files under utils #230
Conversation
MoritzO02
changed the title
Have the headers like this with one *? So it is also wrong in this file? |
|
@MoritzO02 both I fine. I just had a second look at your PR. The reason I missunderstood is that you made a PR with 6 commits. When I get PRs like that I assume that each commit is in itself self contained and should be preserved. Therefore I review each commit individually. This makes reviewing commits easier for me. So for the future I kindly ask you to support me making reviews for your PRs easier. You can do this by presquashing your commits on your side and rebasing the result on top of develop. This allows you also to give the final commit message and I don't have to generate one when squashing the commits on my side here in github. |
MoritzO02
force-pushed
the
feature/add_assembl_from_bools
branch
from
d1f3672 to
18b48a2
Compare
MoritzO02
changed the title
add ASSEMBLE_DWORD_FROM_BOOLS_fct added copyright header to files add ASSEMBLE_BYTE_FROM_BOOLS_fct change folder, add ASSEMBLE_LWORD_FROM_BOOLS_fct add ASSEMBLE_WORD_FROM_BOOLS_fct newer version change VersionInfo
MoritzO02
force-pushed
the
feature/add_assembl_from_bools
branch
from
18b48a2 to
d514192
Compare
|
@azoitl now squashed. |
Created a directory under utils named "assembling" and added four functions. In total eight files.
for issue eclipse-4diac/4diac-ide#221