Added BYTES_TO_XX.fct files to utilis-1.0.0 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 97 files ±0 97 suites ±0 39s ⏱️ -1s Results for commit 70169a3. ± Comparison against base commit 9166b73. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
MartinMelikMerkumians
requested changes
Jul 2, 2024
There was a problem hiding this comment.
As a general remark, TO* named functions are reserved for official cast functions.
The functions introduced here are not casts and introduce a big potential for mistyping names BYTE_TO vs BYTES_TO
Please propose other names, in order to make those functions clearly distinguishable from standardized cast functions
data/typelibrary/utils-1.0.0/typelib/assembling/BYTES_TO_WORD.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/assembling/BYTES_TO_DWORD.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/assembling/ASSEMBLE_DWORD_FROM_BYTES.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/assembling/ASSEMBLE_WORD_FROM_BYTES.fct
Outdated
Show resolved
Hide resolved
diplfranzhoepfinger
approved these changes
Jul 18, 2024
MoritzO02
force-pushed
the
feature/add_BYTES_TO_XX_fct
branch
from
8b2eeeb to
0afb94f
Compare
franz-hoepfinger-4diac
approved these changes
Jul 23, 2024
franz-hoepfinger-4diac
approved these changes
Jul 28, 2024
azoitl
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BYTES_TO_DWORD and BYTES_TO_WORD under the new assemblies directorie in utils-typelib
for issue #221