Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added QUARTERS_TO_XX.fct files under assembling in utils-1.0.0 typelib #241

Merged
merged 16 commits into from
Aug 16, 2024

Conversation

MoritzO02
Copy link

Added QUARTERS_TO_BYTE, QUARTERS_TO_DWORD, QUARTERS_TO_LWORD, QUARTERS_TO_WORD functions.
Also added assembling directory under utils-typelib
for issue #221

Copy link

github-actions bot commented Jul 1, 2024

Test Results

    97 files  ±0      97 suites  ±0   38s ⏱️ -2s
27 173 tests +1  27 173 ✅ +1  0 💤 ±0  0 ❌ ±0 
27 174 runs  +1  27 174 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 4ed7e22. ± Comparison against base commit 9166b73.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
org.eclipse.fordiac.ide.structuredtextalgorithm.tests.STAlgorithmFormattingTest ‑ splitOperatorKeepsLineBreaksTest
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ testMemberAccess
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ testStructInitializerExpression

♻️ This comment has been updated with latest results.

Copy link
Member

@MartinMelikMerkumians MartinMelikMerkumians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please propose different names. as we reseverd TO* functions for the official standardized cast functions,

@MoritzO02 MoritzO02 marked this pull request as draft July 6, 2024 20:43
@MoritzO02 MoritzO02 marked this pull request as ready for review July 15, 2024 17:50
Copy link

@diplfranzhoepfinger diplfranzhoepfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, Approved

@MoritzO02 MoritzO02 force-pushed the feature/add_QUARTERS_TO_XX_fct branch from 12ba699 to 1ebd7a5 Compare July 21, 2024 20:38
@MoritzO02 MoritzO02 force-pushed the feature/add_QUARTERS_TO_XX_fct branch from 1ebd7a5 to 6c669af Compare July 21, 2024 21:03
Copy link

@franz-hoepfinger-4diac franz-hoepfinger-4diac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@azoitl azoitl merged commit 35d619f into eclipse-4diac:develop Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants