-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added QUARTERS_TO_XX.fct files under assembling in utils-1.0.0 typelib #241
Added QUARTERS_TO_XX.fct files under assembling in utils-1.0.0 typelib #241
Conversation
Test Results 97 files ±0 97 suites ±0 38s ⏱️ -2s Results for commit 4ed7e22. ± Comparison against base commit 9166b73. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please propose different names. as we reseverd TO* functions for the official standardized cast functions,
data/typelibrary/utils-1.0.0/typelib/assembling/QUARTERS_TO_BYTE.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/assembling/QUARTERS_TO_LWORD.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/assembling/ASSEMBLE_DWORD_FROM_QUARTERS.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/assembling/ASSEMBLE_LWORD_FROM_QUARTERS.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/assembling/ASSEMBLE_WORD_FROM_QUARTERS.fct
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, Approved
12ba699
to
1ebd7a5
Compare
1ebd7a5
to
6c669af
Compare
data/typelibrary/utils-1.0.0/typelib/assembling/ASSEMBLE_BYTE_FROM_QUARTERS.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/assembling/ASSEMBLE_BYTE_FROM_QUARTERS.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/assembling/ASSEMBLE_DWORD_FROM_QUARTERS.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/assembling/ASSEMBLE_BYTE_FROM_QUARTERS.fct
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Added QUARTERS_TO_BYTE, QUARTERS_TO_DWORD, QUARTERS_TO_LWORD, QUARTERS_TO_WORD functions.
Also added assembling directory under utils-typelib
for issue #221