Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BYTE_TO_XX.fct files under splitting directory in utils-1.0.0 #243

Merged
merged 13 commits into from
Aug 16, 2024

Conversation

MoritzO02
Copy link

Added BYTE_TO_BOOLS and BYTE_TO_QUARTERS functions.
Also added splitting directory under utils typelib folders
for issue #221

Copy link

github-actions bot commented Jul 1, 2024

Test Results

    97 files  ±0      97 suites  ±0   39s ⏱️ -1s
27 173 tests +1  27 173 ✅ +1  0 💤 ±0  0 ❌ ±0 
27 174 runs  +1  27 174 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 2d62f2a. ± Comparison against base commit 9166b73.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
org.eclipse.fordiac.ide.structuredtextalgorithm.tests.STAlgorithmFormattingTest ‑ splitOperatorKeepsLineBreaksTest
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ testMemberAccess
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ testStructInitializerExpression

♻️ This comment has been updated with latest results.

Copy link
Member

@MartinMelikMerkumians MartinMelikMerkumians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please propose different names as we reserved the TO* function names for official standardized casts

Copy link
Member

@MartinMelikMerkumians MartinMelikMerkumians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update type of review to request changes

@MoritzO02 MoritzO02 marked this pull request as draft July 6, 2024 20:43
@MoritzO02 MoritzO02 marked this pull request as ready for review July 15, 2024 17:53
@MoritzO02 MoritzO02 marked this pull request as draft July 15, 2024 18:00
@MoritzO02 MoritzO02 marked this pull request as ready for review July 15, 2024 18:35
Copy link

@diplfranzhoepfinger diplfranzhoepfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, Approved

@MoritzO02 MoritzO02 force-pushed the feature/add_BYTE_TO_XX_fct branch from 8c054b9 to 7fe4d75 Compare July 21, 2024 21:02
@azoitl azoitl merged commit 5bb53a1 into eclipse-4diac:develop Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants