Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LWORD_TO_XX.fct files in splitting to utils-1.0.0 #245

Merged
merged 13 commits into from
Aug 16, 2024
Merged

Added LWORD_TO_XX.fct files in splitting to utils-1.0.0 #245

merged 13 commits into from
Aug 16, 2024

Conversation

MoritzO02
Copy link

Added LWORD_TO_BOOLS and LWORD_TO_QUARTERS functions.
Also added splitting directory under utils typelib
for issue #221

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

Test Results

    97 files  ±0      97 suites  ±0   38s ⏱️ -2s
27 173 tests +1  27 173 ✅ +1  0 💤 ±0  0 ❌ ±0 
27 174 runs  +1  27 174 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 53140f6. ± Comparison against base commit 9166b73.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. 
org.eclipse.fordiac.ide.structuredtextalgorithm.tests.STAlgorithmFormattingTest ‑ splitOperatorKeepsLineBreaksTest

org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ testMemberAccess
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ testStructInitializerExpression

♻️ This comment has been updated with latest results.

MartinMelikMerkumians
MartinMelikMerkumians requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@MartinMelikMerkumians MartinMelikMerkumians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please propose different names as we reserved the TO* function names for official standardized casts

data/typelibrary/utils-1.0.0/typelib/splitting/LWORD_TO_BOOLS.fct Outdated Show resolved Hide resolved
data/typelibrary/utils-1.0.0/typelib/splitting/LWORD_TO_QUARTERS.fct Outdated Show resolved Hide resolved
@MoritzO02 MoritzO02 marked this pull request as draft July 6, 2024 20:44
@MoritzO02 MoritzO02 marked this pull request as ready for review July 15, 2024 18:35
diplfranzhoepfinger
diplfranzhoepfinger approved these changes Jul 18, 2024
View reviewed changes
Copy link

@diplfranzhoepfinger diplfranzhoepfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, Approved

@MoritzO02 MoritzO02 force-pushed the feature/add_LWORD_TO_XX_fct branch from f144f35 to 4f8ebf1 Compare July 21, 2024 21:02
@azoitl azoitl merged commit 46a7ca9 into eclipse-4diac:develop Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franz-hoepfinger-4diac franz-hoepfinger-4diac franz-hoepfinger-4diac approved these changes

@diplfranzhoepfinger diplfranzhoepfinger diplfranzhoepfinger approved these changes

@azoitl azoitl azoitl approved these changes

@MartinMelikMerkumians MartinMelikMerkumians Awaiting requested review from MartinMelikMerkumians

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MoritzO02 @MartinMelikMerkumians @azoitl @diplfranzhoepfinger @franz-hoepfinger-4diac