-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WORD_TO_XX.fct files under splitting directory to utils-1.0.0 #246
Added WORD_TO_XX.fct files under splitting directory to utils-1.0.0 #246
Conversation
Test Results 97 files ±0 97 suites ±0 38s ⏱️ -2s Results for commit 0b20712. ± Comparison against base commit 9166b73. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please propose different names as we reserved the TO* function names for official standardized casts
data/typelibrary/utils-1.0.0/typelib/splitting/WORD_TO_BOOLS.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/splitting/WORD_TO_BOOLS.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/splitting/WORD_TO_BYTES.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/splitting/WORD_TO_BYTES.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/splitting/WORD_TO_QUARTERS.fct
Outdated
Show resolved
Hide resolved
data/typelibrary/utils-1.0.0/typelib/splitting/WORD_TO_QUARTERS.fct
Outdated
Show resolved
Hide resolved
i wrote you in the Forum, to find a better Naming. please discuss there, then we will take it over here. |
@MartinMelikMerkumians BYTE_TO_BOOLS --> SPLIT_BYTE_INTO_BOOLS BOOLS_TO_BYTE --> ASSEMBLE_BYTE_FROM_BOOLS As agreed in the Chat. All others respectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, Approved
data/typelibrary/utils-1.0.0/typelib/splitting/SPLIT_WORD_INTO_BOOLS.fct
Outdated
Show resolved
Hide resolved
84a7a7e
to
682bee9
Compare
Added WORD_TO_BOOLS, WORD_TO_BYTES and WORD_TO_QUARTERS functions.
Also added splitting directory under utils-typelib
for issue #221