Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WORD_TO_XX.fct files under splitting directory to utils-1.0.0 #246

Merged
merged 15 commits into from
Aug 16, 2024

Conversation

MoritzO02
Copy link

Added WORD_TO_BOOLS, WORD_TO_BYTES and WORD_TO_QUARTERS functions.
Also added splitting directory under utils-typelib
for issue #221

Copy link

github-actions bot commented Jul 1, 2024

Test Results

    97 files  ±0      97 suites  ±0   38s ⏱️ -2s
27 173 tests +1  27 173 ✅ +1  0 💤 ±0  0 ❌ ±0 
27 174 runs  +1  27 174 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 0b20712. ± Comparison against base commit 9166b73.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
org.eclipse.fordiac.ide.structuredtextalgorithm.tests.STAlgorithmFormattingTest ‑ splitOperatorKeepsLineBreaksTest
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ testMemberAccess
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ testStructInitializerExpression

♻️ This comment has been updated with latest results.

Copy link
Member

@MartinMelikMerkumians MartinMelikMerkumians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please propose different names as we reserved the TO* function names for official standardized casts

@diplfranzhoepfinger
Copy link

Please propose different names as we reserved the TO* function names for official standardized casts

i wrote you in the Forum, to find a better Naming. 

https://chat.eclipse.org/#/room/!yVjgkwgBPbjMVDziCd:matrix.eclipse.org/$32Q-S09_hZfzB0teQtGf_VzQicSEd6Pb6QVYM4CMp7M?via=matrix.eclipse.org&via=matrix.org

please discuss there, then we will take it over here.

@diplfranzhoepfinger
Copy link

@MartinMelikMerkumians
@MoritzO02

BYTE_TO_BOOLS --> SPLIT_BYTE_INTO_BOOLS

BOOLS_TO_BYTE --> ASSEMBLE_BYTE_FROM_BOOLS

As agreed in the Chat.

All others respectively.

@MoritzO02 MoritzO02 marked this pull request as draft July 6, 2024 20:44
@MoritzO02 MoritzO02 marked this pull request as ready for review July 15, 2024 18:34
Copy link

@diplfranzhoepfinger diplfranzhoepfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, Approved

@MoritzO02 MoritzO02 force-pushed the feature/add_WORD_TO_XX_fct branch from 84a7a7e to 682bee9 Compare July 21, 2024 21:02
@azoitl azoitl merged commit ff8eb29 into eclipse-4diac:develop Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants