Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for modbus-ng interface #477

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mx990
Copy link
Member

@mx990 mx990 commented Sep 13, 2024

No description provided.

Copy link

github-actions bot commented Sep 13, 2024

Test Results

   111 files  +    4     111 suites  +4   48s ⏱️ -2s
29 177 tests +1 817  29 177 ✅ +1 817  0 💤 ±0  0 ❌ ±0 
29 178 runs  +1 817  29 178 ✅ +1 817  0 💤 ±0  0 ❌ ±0 

Results for commit 9464978. ± Comparison against base commit 36da1b8.

This pull request removes 23 and adds 1837 tests. Note that renamed tests count towards both.
IDE
IDE, "4diac$NIDE"
IDE, '4diac$NIDE'
org.eclipse.fordiac.ide.test.model.eval.fb.SimpleFBEvaluatorTest ‑ testDirectlyDerivedAttribute
org.eclipse.fordiac.ide.test.model.eval.fb.SimpleFBEvaluatorTest ‑ testStructAttribute
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[14] StringValueConverter, '4diac$NIDE', 4diac
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[15] StringValueConverter, '4diac$P$R$TIDE', 4diac
 IDE
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[22] WStringValueConverter, "4diac$NIDE", 4diac
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[23] WStringValueConverter, "4diac$P$R$TIDE", 4diac
 IDE
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[27] StructValueConverter [NumericValueConverter], (a := 17, b := 4), {b=4, a=17}
…
org.eclipse.fordiac.ide.model.datatype.helper.TypeDeclarationParserTest ‑ testCheckVariableArrayBounds
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentMLBlockReformatTest
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentStabilityTestMLBlock
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentStabilityTestMLUnwrapped
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentStabilityTestMLWrapped
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentStabilityTestSLUnwrapped
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentStabilityTestSLWrapped
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.STFunctionValidatorPartialAccessTest ‑ testValidPartialAccessOnArraySubscript
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.STFunctionValidatorTest ‑ testBinaryOperatorResultType(String, String, String) 1000: LT with WORD and BOOL
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.STFunctionValidatorTest ‑ testBinaryOperatorResultType(String, String, String) 1001: LE with WORD and BOOL
…

♻️ This comment has been updated with latest results.

@diplfranzhoepfinger
Copy link

please do not delete. i still want to bring this working.
have one Customer in Need of this.

@K019N
Copy link

K019N commented Jan 28, 2025

Mabye you have a typo in ModbusBusAdapter.adp on line 11: "" -- you use zero instead of letter O??

@mx990
Copy link
Member Author

mx990 commented Jan 28, 2025

You are correct, thanks for noting!

@diplfranzhoepfinger
Copy link

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants