-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapterized Interfaces #864
base: develop
Are you sure you want to change the base?
Adapterized Interfaces #864
Conversation
Add new AdapterType AX for 1 Event and 1 Bool
Test Results 113 files ±0 113 suites ±0 49s ⏱️ ±0s For more details on these failures, see this check. Results for commit bcad466. ± Comparison against base commit a777a49. ♻️ This comment has been updated with latest results. |
<Dependencies> | ||
<Required SymbolicName="core" Version="1.0.0"/> | ||
</Dependencies> | ||
<Product Name="Convert" SymbolicName="adapterized" Comment="Standard Library - Adapterized"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have a more speaking name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapter-Supported
Adapter-Enabled
Adapter-Integrated
What do you think?
Add new IXa FBType with event and data connections. Add new FBType "QXA" for boolean output data with events, vars, and connections. Add boolean OR function blocks AX_OR_2, AX_OR_3, and AX_OR_4. Detailed XML descriptions for each block with input/output connections.
127b248
to
e9a0dec
Compare
a6b7326
to
bcad466
Compare
@azoitl if you have time, pls do a Review. |
@@ -0,0 +1,40 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<FBType Name="AX_OR_2" Comment="FB to calculate boolean OR" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azoitl this we would then also implement Generic ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know how easy a generic adapter based FB can be implemented. But you can give it a try.
Adapterized Interfaces
First few Blocks