Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Fix a problem with a platform-specific path conversion. #594

Conversation

oheger-bosch
Copy link
Contributor

Issue: eclipse#591.

CSVArtifactMapper tries to convert paths to source files to relative
paths, so that they are not specific to a local configuration.
However, for absolute paths that are not below the base directory,
this obviously does not work reliably on all platforms - and does not
make any sense either. So such paths are now stored as absolute paths.

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to? (Refer to issue here)
  • How is it solving the issue?
  • Did you add or update any new dependencies that are required for your change?

Request Reviewer

You can add desired reviewers here with an @mention.
@blaumeiser-at-bosch @neubs-bsi

Type of Change

Mention one of the following:
bug fix | new feature | improvements | documentation update | CI | Other

Type of change:
improvements

How Has This Been Tested?

If you have added any changes that require additional tests, or changes in tests, you should implement them and describe them here.
All test that passed before your contribution should pass after it as well.
A new test case has been added to check the concrete problem.

Checklist

Must:

  • All related issues are referenced in commit messages

Optional: (delete if not applicable)

  • I have provided tests for the changes (if there are changes that need additional tests)
  • I have updated the documentation accordingly to my changes

Issue: eclipse#591.

CSVArtifactMapper tries to convert paths to source files to relative
paths, so that they are not specific to a local configuration.
However, for absolute paths that are not below the base directory,
this obviously does not work reliably on all platforms - and does not
make any sense either. So such paths are now stored as absolute paths.

Resolves eclipse-archived#591

Signed-off-by: Oliver Heger <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@blaumeiser-at-bosch
Copy link
Contributor

blaumeiser-at-bosch commented Sep 30, 2020

It even builds on my machine

@oheger-bosch oheger-bosch merged commit 2063ebd into eclipse-archived:master Sep 30, 2020
@oheger-bosch oheger-bosch deleted the oheger-bosch/bug/#591_source_file_paths branch September 30, 2020 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants