RPM signing feature #141
RPM signing feature #141
Conversation
|
Also added a couple of code snippets in ModifyContextImpl.java and ChannelServiceImpl.java for deleting empty directories after channels were cleared or deleted |
|
Thanks for the PR! I will take a look in the next few days. Two more formal things: you will need to sign the Eclipse ECA and add the You would also need to add proper license headers for the new files and add yourself to the license header of the files you modified. I also saw that you modified the code of the RPM utilities. As indicated in issue #137, this functionality is being relocated into a new project, which only focuses on this aspect. It would be great if you could create a PR in this project (https://github.com/eclipse/packager). I hope to be able to create a new release of that project soon, so I could refactor Package Drone to actually pick up those libraries and re-use the functionality. |
|
Signed the ECA, added license info and signatures. I had forgotten about contributing to the eclipse packager project and I don't have time today to create a pull request but I will take care of it tomorrow! |
| @@ -1,5 +1,16 @@ | |||
| /******************************************************************************* | |||
| * Contract No: FA8750-14-D-0037 | |||
There was a problem hiding this comment.
Could you please align that with the other headers:
e.g.:
Copyright (c) 2019 Trident Systems, Inc.
There was a problem hiding this comment.
Certainly. I've added that line to each file containing that header.
There was a problem hiding this comment.
I am sorry, but I was assuming to drop:
* Contract No: FA8750-14-D-0037
* Contractor Name: Trident Systems, Inc.
* Contractor Address: 10201 Fairfax Blvd. Suite 300, Fairfax, VA
as well. So that the license headers match the existing license headers.
There was a problem hiding this comment.
Oh, I see. Sure I can do that as well.
|
Ok, it looks like there are still commits, signed off with an e-mail address, that has not signed the ECA. Maybe you can squash the commits and force-push the result to this PR. Only using the correct e-mail address in the process. |
wbfunk92
force-pushed
the
rpmsign
branch
2 times, most recently
from
d7aec48 to
132876c
Compare
|
Ok yes, I went back and squashed all the commits together and signed off
with my work email. Just to be safe I signed the ECA with my personal email
which I use for my github account. Does that seem like it will suffice?
Sorry for the inconvenience.
…On Tue, Sep 3, 2019 at 4:13 AM Jens Reimann ***@***.***> wrote:
Ok, it looks like there are still commits, signed off with an e-mail
address, that has not signed the ECA. Maybe you can squash the commits and
force-push the result to this PR. Only using the correct e-mail address in
the process.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#141>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHO7IUHXZODOPOOKPAEVLDDQHYMCRANCNFSM4H7FTUVA>
.
|
|
I think you misspelled the footer entry You should be able to see the validation results in the checks box of the PR. The check is named |
Signed-off-by: Walker Funk <[email protected]>
|
Haha I will get it right one of these days. I see what you mean now. After amending the commit it seems to be approving the eclipsefdn/eca check. |
RSA signing feature added alongside YUM signing service for RPM channels