Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jcasc node configuration for equinox #385

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heurtematte
Copy link
Contributor

@heurtematte heurtematte commented Jul 11, 2024

Add missing mail-watcher-plugin plugin for node watcher configuration.

Signed-off-by: sebastien.heurtematte <[email protected]>
@heurtematte
Copy link
Contributor Author

@HannesWell I found the culprit, it was a missing plugin.

Working on the configuration.yml file, I have figured out it was a symlink to eclipse.platform.releng nodes configuration.

I wonder if you want all releng node working with this instance.

I have replicated a few credentials to allow some nodes to work:

  • b9h15-macos11-x86_64
  • rs68g-win10
  • zyt5z-centos83
  • nc1ht-macos11-arm64

But still some nodes need to be configured but have been provided by the project:

  • centos-aarch64-1
  • centos-aarch64-2
  • centos-aarch64-3
  • centos-aarch64-4

And what about those nodes:

  • ppcle-buildTest
  • ppcle-test
  • qa6xd-win11
  • rie8t-win11-arm64

@HannesWell
Copy link
Contributor

@HannesWell I found the culprit, it was a missing plugin.

Great!

Working on the configuration.yml file, I have figured out it was a symlink to eclipse.platform.releng nodes configuration.

That's right. This was the main idea in #379.
I was hoping that linking the main config file would ensure that future changes are always synced 'automatically' and it would minimize future maintenance work as well as the work to add the agents initially.

I wonder if you want all releng node working with this instance.

Technically we only need only the nodes that have a native.builder... label and among them even one per platform would be sufficient.
But my assumption was it would be simpler to just link the entire file.

Would it be possible to just use the same credentials as for releng?

But still some nodes need to be configured but have been provided by the project:

  • centos-aarch64-1
  • centos-aarch64-2
  • centos-aarch64-3
  • centos-aarch64-4

We probably just need one of these for linux.aarch.
But I see the problem. But to keep this consistent would it be possible link that as well in the jiro.jsonnet of equinox/platform JIPP? Similar to

jiro+ {
  "config.json"+: import "config.jsonnet",
  "k8s/statefulset.json"+: import "../eclipse.platform.releng/k8s/statefulset.jsonnet",

...

}

And what about those nodes:

  • ppcle-buildTest
  • ppcle-test
  • qa6xd-win11
  • rie8t-win11-arm64

As described above having rie8t-win11-arm64 and ppcle-buildTest would probably be sufficient.

@heurtematte
Copy link
Contributor Author

Would it be possible to just use the same credentials as for releng?

np

We probably just need one of these for linux.aarch.

These are agents provided by the project. There is not much I can do on my side I guess.

But to keep this consistent would it be possible link that as well in the jiro.jsonnet of equinox/platform JIPP?

See my last commit: 3322eac

NOTE: not sure the ENV value is still necessary cause it is related to gerrit plugin according to the comment.
# Required for gerrit-code-review https://github.com/jenkinsci/gerrit-code-review-plugin/releases/tag/gerrit-code-review-0.4.6,

Only known-hosts matter.

As described above having rie8t-win11-arm64 and ppcle-buildTest would probably be sufficient.

rie8t-win11-arm64 would required to configure the agent.
ppcle-buildTest: unable to find the origin of this agent.

@HannesWell
Copy link
Contributor

Would it be possible to just use the same credentials as for releng?

np

I hope this means no problem and not not possible 😅

We probably just need one of these for linux.aarch.

These are agents provided by the project. There is not much I can do on my side I guess.

I don't understand what that means exactly? Is this a custom machine provided by a working-group member?
In general I'm convinced the platform project is willing to share at least one of these machines with Equinox.
Can you tell me who has to be asked to make that possible?

But to keep this consistent would it be possible link that as well in the jiro.jsonnet of equinox/platform JIPP?

See my last commit: 3322eac

NOTE: not sure the ENV value is still necessary cause it is related to gerrit plugin according to the comment. # Required for gerrit-code-review https://github.com/jenkinsci/gerrit-code-review-plugin/releases/tag/gerrit-code-review-0.4.6,

Only known-hosts matter.

I agree the ENV value is probably obsolete (wanted to suggest to clean that up anyways).
The addition looks good, but I wonder if the master-known-hosts.yml file can also be considered a template so that we can sym-link it and just replace the few different values with {{ project.remoteFSSuffix }} just like it was done for the jenkins/configuration.yml?
If that's possible we should probably rename remoteFSSuffix in the config.jsonnet to something more general like short-name.

As described above having rie8t-win11-arm64 and ppcle-buildTest would probably be sufficient.

rie8t-win11-arm64 would required to configure the agent.

What does that mean?

ppcle-buildTest: unable to find the origin of this agent.

You mean where the following configuration connects to?

- permanent:
name: "ppcle-buildTest"
labelString: "ppctest ppcbuild swt.natives-gtk.linux.ppc64le native.builder-gtk.linux.ppc64le"
remoteFS: "/home/swtbuild/build/{{ project.remoteFSSuffix }}/"
numExecutors: 1
mode: EXCLUSIVE
retentionStrategy: "always"
launcher:
inbound:
webSocket: true
workDirSettings:
disabled: false
failIfWorkDirIsMissing: false
internalDir: "remoting"

@heurtematte
Copy link
Contributor Author

I hope this means no problem and not not possible 😅

no problem 😃

I don't understand what that means exactly? Is this a custom machine provided by a working-group member?
In general I'm convinced the platform project is willing to share at least one of these machines with Equinox.
Can you tell me who has to be asked to make that possible?

@fredg02 do you know where those machines come from? centos-aarch64-1, ... I only have this info: Agent provided by the project
And who to ask?

I agree the ENV value is probably obsolete (wanted to suggest to clean that up anyways).

ok

The addition looks good, but I wonder if the master-known-hosts.yml file can also be considered a template

Not really, this file is not yet part of the process. This configuration is pushed manually to our cluster.

rie8t-win11-arm64 would required to configure the agent. What does that mean?

Configure a new specific jenkins agent on the W11 machine for this instance.

ppcle-buildTest: unable to find the origin of this agent.

I don't know who provide this machine.

fredg02 added a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants