Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace autovalue with java records, add service tests #254

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Replace autovalue with java records, add service tests #254

merged 5 commits into from
Oct 25, 2023

Conversation

netomi
Copy link
Contributor

@netomi netomi commented Oct 23, 2023 •
edited
Loading

This PR replaces any use of AutoValue / Moshi with plain java records (plus record-builder) and jsonb.

Additional changes include:

  • add unit tests for NotarizationService
  • cleanup the use of OkHttClient that is only used by Altool notarizer
  • update README with latest information about build
  • add ci workflow
  • add dependency update workflow to capture vulnerabilities in transitive dependencies

@mbarbero
Copy link
Member

Awesome, much cleaner. Thanks!

@netomi netomi merged commit 79bc673 into eclipse-cbi:main Oct 25, 2023
5 checks passed
@netomi netomi deleted the records branch October 25, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarbero mbarbero mbarbero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netomi @mbarbero