Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release workflow #257

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

netomi
Copy link
Contributor

@netomi netomi commented Oct 27, 2023

This fixes #255 .

This PR includes various improvements:

  • make release fully automated using the maven release plugin
  • separate sbom related plugins to a separate profile
  • small improvements to the existing workflows to ensure they are only run in this repo not in forks

In order to make a release, just trigger the release workflow manually. The workflow will automatically setup the version for the release, tag, upload the release and bump the version to the next development version afterwards.

The release is prepared as draft, once everything is fine, you can publish it.

I tested the workflow extensively in my own fork, but cleaned up all generated tags / releases after it was finally successful. In order for the workflow to succeed, various things have to be setup correctly in the fork, so running the workflow as is in my fork will eventually fail. So after the workflow was working I modified the branch for the PR to the eclipse-cbi version and squashed all commits.

Edit: I have now run the release workflow in my fork with necessary changes (netomi@ce51ff0): https://github.com/netomi/macos-notarization-service/actions/runs/6670304472 , the workflow just failed in the last step, uploading the artifacts to the draft release as the artifacts were already there (from a previous run).

Resulting in this release: https://github.com/netomi/macos-notarization-service/releases/tag/v1.2.1
Pom is updated afterwards: netomi@d150273

Using the maven release plugin is a bit of a pain. In the long run we should use jreleaser and also get rid of the release drafter imho.

@netomi netomi requested a review from mbarbero October 27, 2023 16:02
Signed-off-by: Thomas Neidhart <[email protected]>
@netomi netomi merged commit d6f2e78 into eclipse-cbi:main Nov 1, 2023
5 checks passed
@netomi netomi deleted the improve-build-workflow branch November 1, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve release workflow to fully automate updating the pom
2 participants