Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #255 .
This PR includes various improvements:
In order to make a release, just trigger the release workflow manually. The workflow will automatically setup the version for the release, tag, upload the release and bump the version to the next development version afterwards.
The release is prepared as draft, once everything is fine, you can publish it.
I tested the workflow extensively in my own fork, but cleaned up all generated tags / releases after it was finally successful. In order for the workflow to succeed, various things have to be setup correctly in the fork, so running the workflow as is in my fork will eventually fail. So after the workflow was working I modified the branch for the PR to the eclipse-cbi version and squashed all commits.
Edit: I have now run the release workflow in my fork with necessary changes (netomi@ce51ff0): https://github.com/netomi/macos-notarization-service/actions/runs/6670304472 , the workflow just failed in the last step, uploading the artifacts to the draft release as the artifacts were already there (from a previous run).
Resulting in this release: https://github.com/netomi/macos-notarization-service/releases/tag/v1.2.1
Pom is updated afterwards: netomi@d150273
Using the maven release plugin is a bit of a pain. In the long run we should use jreleaser and also get rid of the release drafter imho.