Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jreleaser, remove release-drafter. #279

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

netomi
Copy link
Contributor

@netomi netomi commented Dec 8, 2023

This fixes #263 .

The release workflow has been updated to use the latest version of jreleaser.
Additional changes:

  • remove release-drafter
  • add custom action to bump version for next development cylce

@netomi netomi requested a review from mbarbero December 8, 2023 10:16
@aalmiray
Copy link

aalmiray commented Dec 8, 2023

The BINARY distribution type is supposed to be used for platform specific executables. If the project provides a Java based binary then the JAVA_BINARY distribution type is preferred, which is also the default value.

https://jreleaser.org/guide/latest/concepts/distributions/binary.html

https://jreleaser.org/guide/latest/concepts/distributions/java-binary.html

The choice of distribution type determines which other features may be used later, such as package managers.

@netomi
Copy link
Contributor Author

netomi commented Dec 8, 2023

marking as draft, doing some tests.

@netomi netomi changed the title Use jreleaser, remove release-drafter. WIP: Use jreleaser, remove release-drafter. Dec 8, 2023
@netomi
Copy link
Contributor Author

netomi commented Dec 8, 2023

Finally got it working: https://github.com/netomi/macos-notarization-service/actions/runs/7144907502

Need to cleanup the PR and squash commits.

@netomi netomi force-pushed the switch-to-jreleaser branch from 51448de to 961ed73 Compare December 9, 2023 22:57
@netomi netomi changed the title WIP: Use jreleaser, remove release-drafter. Use jreleaser, remove release-drafter. Dec 9, 2023
@netomi
Copy link
Contributor Author

netomi commented Dec 9, 2023

cleaned up PR, added additional checks for the release workflow:

  • check if a tag with the same name already exists
  • only allow releases from the main branch

@netomi
Copy link
Contributor Author

netomi commented Dec 10, 2023

@netomi netomi merged commit 376b71d into eclipse-cbi:main Dec 11, 2023
6 checks passed
@netomi netomi deleted the switch-to-jreleaser branch December 11, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use jreleaser for publishing releases
3 participants