Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not install Tarpaulin from Devcontainer #38

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Do not install Tarpaulin from Devcontainer #38

merged 1 commit into from
Nov 14, 2022

Conversation

bastbu
Copy link
Contributor

@bastbu bastbu commented Nov 14, 2022 •
edited
Loading

Fixes #33

Description

Tarpaulin cannot be compiled on Docker on M1 MacBooks but has an (unreleased) fix ready for this issue. As long as it's not yet released, we do not install Tarpaulin with the Devcontainer.

We track reinstalling Tarpaulin in #39.

@bastbu bastbu mentioned this pull request Nov 14, 2022
Open
1 task
@bastbu bastbu marked this pull request as ready for review November 14, 2022 11:01
@bastbu bastbu mentioned this pull request Nov 14, 2022
Closed
atifaziz
atifaziz reviewed Nov 14, 2022
View reviewed changes
Copy link
Contributor

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway we can make its install conditional instead of completely removing it?

@atifaziz atifaziz merged commit 285b00c into eclipse-chariott:main Nov 14, 2022
@bastbu
Copy link
Contributor Author

bastbu commented Nov 14, 2022

Anyway we can make its install conditional instead of completely removing it?

Valid suggestion. Since this would require an ARG on the Dockerfile (and hence a manual change in the devcontainer.json to change the configuration), this would need to be documented and requires manual intervention. As the removal of Tarpaulin is temporary, it might not be worth the effort.

@bastbu bastbu deleted the fix/remove-tarpaulin branch November 14, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atifaziz atifaziz atifaziz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev container does not work on ARM based machine
2 participants
@bastbu @atifaziz