-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not dispatch a warning, if the git provider is not supported #1306
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
- Coverage 91.68% 91.60% -0.08%
==========================================
Files 498 499 +1
Lines 45447 45462 +15
Branches 3166 3158 -8
==========================================
- Hits 41668 41647 -21
- Misses 3748 3783 +35
- Partials 31 32 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1306 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1306", name: che-dashboard}]}}]" |
What does this PR do?
Do not dispatch a warning, if the git provider is not supported.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23304
Is it tested? How?
quay.io/eclipse/che-dashboard:pr-1306
https://gitea.com/ivinokur/test.git
See workspace starts from the default devfile without any warnings.
Release Notes
Docs PR