Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: annotations typo in CheCluster example #2757

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Jul 15, 2024

What does this pull request change?

Fixes typo in the field name

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Che 7.88, DS 3.15

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@dkwon17 dkwon17 requested review from deerskindoll and a team as code owners July 15, 2024 18:20
@dkwon17 dkwon17 requested a review from ibuziuk July 15, 2024 18:20
Copy link

github-actions bot commented Jul 15, 2024

🎊 Navigate the preview: https://669689f7f619af38084dce19--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Jul 15, 2024

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dkwon17
Copy link
Contributor Author

dkwon17 commented Jul 15, 2024

Thank you for the review @deerskindoll , can I merge this PR?

@deerskindoll
Copy link
Contributor

Thank you for the review @deerskindoll , can I merge this PR?

sure, go ahead! can you please cherry-pick it as well while you're at it?

@dkwon17
Copy link
Contributor Author

dkwon17 commented Jul 16, 2024

There was another small typo, I just fixed it.

cherry-pick it as well while you're at it?

Sounds good, I will cherry pick it too

@dkwon17 dkwon17 merged commit 71e6ac3 into eclipse-che:main Jul 16, 2024
5 of 6 checks passed
dkwon17 added a commit to dkwon17/che-docs that referenced this pull request Jul 16, 2024
dkwon17 added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants