Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: advanced config properties #2816

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deerskindoll
Copy link
Contributor

What does this pull request change?

re-added advanced content properties table

What issues does this pull request fix or reference?

eclipse-che/che#23130

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@deerskindoll deerskindoll requested a review from a team as a code owner November 12, 2024 15:26
@deerskindoll deerskindoll requested a review from ibuziuk November 12, 2024 15:26
Copy link

github-actions bot commented Nov 12, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Nov 12, 2024

🎊 Navigate the preview: 🎊

@ibuziuk
Copy link
Member

ibuziuk commented Nov 13, 2024

@deerskindoll can we have the preview link for those changes?

@ibuziuk ibuziuk requested review from tolusha and vinokurig December 6, 2024 18:19
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha @vinokurig please, review
I'm a bit afraid that a lot of options might be obsolete / misleading if we re-enable automatic generation

@vinokurig
Copy link
Contributor

I agree with @ibuziuk, there are a lot of outdated configurations related to the old workspace architecture in the https://github.com/eclipse-che/che-server/blob/main/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties

Copy link
Contributor

@vinokurig vinokurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants