-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change path for plugin reg readiness probe #1894
Conversation
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
@svor: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: svor, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.17 :: operator_3.x/394: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7691: Console, Changes, Git Data |
Build 3.17 :: push-latest-container-to-quay_3.x/4915: Console, Changes, Git Data |
Build 3.17 :: get-sources-rhpkg-container-build_3.x/7683: devspaces-operator : 3.x :: Build 64092546 : quay.io/devspaces/devspaces-rhel8-operator:3.17-8 |
Build 3.17 :: update-digests_3.x/7517: Console, Changes, Git Data |
Build 3.17 :: operator_3.x/394: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7691 triggered |
Build 3.17 :: operator-bundle_3.x/3608: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7693: Console, Changes, Git Data |
Build 3.17 :: push-latest-container-to-quay_3.x/4917: Console, Changes, Git Data |
Build 3.17 :: copyIIBsToQuay/2784: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7693: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7685 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.17 :: operator-bundle_3.x/3608: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7693 triggered |
Build 3.17 :: dsc_3.x/1991: Console, Changes, Git Data |
Build 3.17 :: update-digests_3.x/7517: Detected new images: rebuild operator-bundle |
Build 3.17 :: dsc_3.x/1991: 3.17.0-CI |
Build 3.17 :: copyIIBsToQuay/2784: 3.17 |
What does this PR do?
Since plugin registry pod provides only openvsx server, the readiness probe should check id openvsx server is available.
For that
/openvsx/api/version
is requested by readiness probeDepends on redhat-developer/devspaces#1099
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Related to eclipse-che/che#23074
How to test this PR?
OpenShift
on Minikube
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.