Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change path for plugin reg readiness probe #1894

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

svor
Copy link
Contributor

@svor svor commented Sep 6, 2024

What does this PR do?

Since plugin registry pod provides only openvsx server, the readiness probe should check id openvsx server is available.
For that /openvsx/api/version is requested by readiness probe

Depends on redhat-developer/devspaces#1099

Screenshot/screencast of this PR

screenshot-nimbusweb me-2024 09 06-15_12_45

What issues does this PR fix or reference?

Related to eclipse-che/che#23074

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec:
  components:
    pluginRegistry:
      openVSXURL: ''
      deployment:
        containers:
          - image: quay.io/vsvydenk/pluginregistry-rhel8:46
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml
  1. Check that plugin registry pod is running

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@svor svor self-assigned this Sep 6, 2024
Signed-off-by: Valeriy Svydenko <[email protected]>
@eclipse-che eclipse-che deleted a comment from openshift-ci bot Sep 6, 2024
Copy link

openshift-ci bot commented Sep 6, 2024

@svor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy a5f1afa link true /test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: svor, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit f3f8883 into main Sep 10, 2024
20 of 21 checks passed
@svor svor deleted the sv-registry-rediness-probe branch September 10, 2024 07:25
@devstudio-release
Copy link

Build 3.17 :: operator_3.x/394: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: operator_3.x/394: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7691 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: copyIIBsToQuay/2784: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7693: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7685 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3608: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7693 triggered

@devstudio-release
Copy link

Build 3.17 :: dsc_3.x/1991: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: update-digests_3.x/7517: SUCCESS

Detected new images: rebuild operator-bundle
* devspaces-operator
* pluginregistry; /DS_CI/operator-bundle_3.x/3608 triggered

@devstudio-release
Copy link

Build 3.17 :: dsc_3.x/1991: SUCCESS

3.17.0-CI

@devstudio-release
Copy link

Build 3.17 :: copyIIBsToQuay/2784: SUCCESS

3.17
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.17-5
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ s390x-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.17-v4.16-809002- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.16-809002- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.16-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.15-809001- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.15-809001- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.15-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.14-809000- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.14-809000- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.14-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.13-808999- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.13-808999- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.13-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.12-808998- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.12-808998- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.17-v4.16-809002- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.16-809002- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.16-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.15-809001- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.15-809001- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.15-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.14-809000- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.14-809000- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.14-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.13-808999- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.13-808999- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.13-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.12-808998- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.12-808998- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.17-v4.16-809002- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.16-809002- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.16-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.15-809001- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.15-809001- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.15-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.14-809000- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.14-809000- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.14-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.13-808999- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.13-808999- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.13-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.12-808998- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.12-808998- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.12-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants