Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove js-debug extension #1769

Merged
merged 1 commit into from
Aug 31, 2023
Merged

chore: remove js-debug extension #1769

merged 1 commit into from
Aug 31, 2023

Conversation

svor
Copy link
Contributor

@svor svor commented Aug 30, 2023

What does this PR do?

Removes built-in js-debug extension from the list of embedded extensions

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4817

How to test this PR?

  • Deploy che
  • Update eclipse-che CR to use internal plugin registry with custom image:
    pluginRegistry:
    deployment:
    containers:
    - image: 'quay.io/vsvydenk/che-plugin-registry:up'
    openVSXURL: ''
  • Start any workspace and check the list of available extensions, js-debug should not be there
    screenshot-eclipse-che apps rosa xw5kt-fmr6p-pn5 pddx p3 openshiftapps com-2023 08 30-11_58_50

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Valeriy Svydenko <[email protected]>
@svor svor self-assigned this Aug 30, 2023
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit 78f5899 into main Aug 31, 2023
16 checks passed
@svor svor deleted the sv-remove-js-debug branch August 31, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants