Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add vscode-dotnet-runtime extension #1772

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

svor
Copy link
Contributor

@svor svor commented Sep 4, 2023

What does this PR do?

Adds ms-dotnettools.vscode-dotnet-runtime extension into the list of embedded extensions as it is required by the latest version of muhammad-sammy.csharp

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#22470

How to test this PR?

Build the registry

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@svor svor self-assigned this Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Click here to review and test in web IDE: Contribute

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

@svor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v10-plugins-test-pr-check 306acda link true /test v10-plugins-test-pr-check
ci/prow/v10-images 306acda link true /test v10-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit 0225a53 into main Sep 4, 2023
11 checks passed
@svor svor deleted the sv-add-dotnet-runtime branch September 4, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants