Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR checks (smoke test and API) #1793

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Add PR checks (smoke test and API) #1793

merged 1 commit into from
Oct 5, 2023

Conversation

svor
Copy link
Contributor

@svor svor commented Sep 22, 2023

What does this PR do?

Adds 2 PR checks:

  • Smoke Test / smoke-test (pull_request). It is running on minikube and configured in GitHub workflow file. This check uses factory flow and GUI to check conditions.
  • ci/prow/v12-plugins-test-pr-check. This scenario is running on OpenShift v12, all coniguration files are located in .ci folder. It uses API to generate a devworkspace and start it by oc commands, no GUI usage.

Both PR checks verify if the workspace is started and the project is cloned. The workspace uses an editor from a plugin registry image that was built from the PR that should be validated.

What issues does this PR fix or reference?

eclipse-che/che#22215

How to test this PR?

See PR checks in this PR.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@svor
Copy link
Contributor Author

svor commented Sep 23, 2023

/retest

2 similar comments
@svor
Copy link
Contributor Author

svor commented Sep 25, 2023

/retest

@svor
Copy link
Contributor Author

svor commented Sep 25, 2023

/retest

@svor
Copy link
Contributor Author

svor commented Sep 26, 2023

/test all

@svor
Copy link
Contributor Author

svor commented Sep 26, 2023

/retest

@svor
Copy link
Contributor Author

svor commented Sep 26, 2023

/test all

@svor
Copy link
Contributor Author

svor commented Sep 26, 2023

/retest

2 similar comments
@svor
Copy link
Contributor Author

svor commented Oct 2, 2023

/retest

@svor
Copy link
Contributor Author

svor commented Oct 2, 2023

/retest

@openshift-merge-robot
Copy link

@svor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v12-plugins-test-pr-check 7420be2 link true /test v12-plugins-test-pr-check
ci/prow/v12-images ba8913c link true /test v12-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Valeriy Svydenko <[email protected]>
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1793 (08421c3) into main (fa10086) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1793   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          563       563           
  Branches        88        88           
=========================================
  Hits           563       563           

@svor svor changed the title ----> DON'T MERGE <---- feat: add smoke tests Add PR checks (smoke test and API) Oct 5, 2023
@svor svor requested a review from artaleks9 October 5, 2023 07:44
@artaleks9
Copy link

Looks good to merge

@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit 21a0a18 into main Oct 5, 2023
19 checks passed
@svor svor deleted the sv-test-ci branch October 5, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants