Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade local plugin registry to use openvsx-server 0.14.5 #1899

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

svor
Copy link
Contributor

@svor svor commented Mar 19, 2024

What does this PR do?

  • Upgrade openvsx-server base image to 0.14.5
  • Set timeout after publishing an extension for the activation

Screenshot/screencast of this PR

screenshot-nimbusweb me-2024 03 19-14_59_04

screenshot-nimbusweb me-2024 03 19-14_56_30

What issues does this PR fix or reference?

eclipse-che/che#22826

How to test this PR?

  • Deploy Eclipse Che on the cluster
  • Update che-server CR in the OS console to use custom plugin registry:
    pluginRegistry:
      deployment:
        containers:
          - image: 'quay.io/vsvydenk/che-plugin-registry:14.3'
      openVSXURL: ''
  • Start any workspace
  • Extensions should be available on the extension's view and it should be possible to install any extension

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Valeriy Svydenko <[email protected]>
@svor svor self-assigned this Mar 19, 2024
Copy link

Click here to review and test in web IDE: Contribute

@svor svor requested a review from artaleks9 March 19, 2024 14:19
Copy link
Contributor

@vinokurig vinokurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: svor, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Mar 21, 2024
Copy link

openshift-ci bot commented Mar 21, 2024

New changes are detected. LGTM label has been removed.

@svor svor changed the title chore: upgrade local plugin registry to use openvsx-server 0.14.3 chore: upgrade local plugin registry to use openvsx-server 0.14.5 Mar 21, 2024
@svor
Copy link
Contributor Author

svor commented Mar 22, 2024

/retest

@svor svor merged commit ccdf42d into main Mar 22, 2024
18 checks passed
@svor svor deleted the sv-openvsx-14.3 branch March 22, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants