[WIP] Upgrade VS Code Metals, the Scala language client, to version 1.9.5 #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideeffffect
requested review from
benoitf,
ericwill,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
sideeffffect
changed the title
Signed-off-by: sideeffffect <[email protected]>
sideeffffect
force-pushed
the
scala-metals-1.9.5
branch
from
9d06796
to
0790a45
Compare
ericwill
reviewed
Nov 6, 2020
| firstPublicationDate: "2020-11-02" | ||
| spec: | ||
| containers: | ||
| - image: "quay.io/gattytto/scala090:0.9.0" |
There was a problem hiding this comment.
What's different about this image? It's probably best to update the side in che-sidecar-scala, no?
There was a problem hiding this comment.
I've created a ticket to fix the image che-dockerfiles/che-sidecar-scala#10
There was a problem hiding this comment.
when this one is merged you may use the new sidecar ID for quay.io/eclipse/che-sidecar-scala:0.9.0-xyz here @sideeffffect
gattytto
reviewed
Nov 10, 2020
| @@ -344,7 +344,7 @@ | |||
| }, | |||
| { | |||
| "repository": "https://github.com/scalameta/metals-vscode", | |||
| "revision": "v1.9.4", | |||
| "revision": "v1.9.5", | |||
| "sidecar": { | |||
| "image": "quay.io/eclipse/che-sidecar-scala:0.9.0-b92a5f9", | |||
There was a problem hiding this comment.
here you will need to use the new ID after https://github.com/eclipse/che-plugin-registry/pull/682/files is merged @sideeffffect
Signed-off-by: Eric Williams <[email protected]>
Fixes eclipse-che/che#18183 Signed-off-by: Eric Williams <[email protected]>
* FUSETOOLS2-805 - update didact version to 0.1.18 Signed-off-by: [email protected] <[email protected]> * update vscode-extensions.json Signed-off-by: [email protected] <[email protected]>
* hlasm-language-support 0.11.1 New version of plugin hlasm-language-support 0.11.1 Signed-off-by: Filip Kroupa <[email protected]> * Remove hlasm-language-support 0.11.0 Remove older plugin version, as only one should be in the registry. See eclipse-che/che#18183 Signed-off-by: Filip Kroupa <[email protected]>
* Plugin registry housekeeping * Remove old didact extension * Delete redhat/php plugin as we have the latest one under the publisher name * Move redhat/php-debug to the proper publisher/plugin-name folder Signed-off-by: Eric Williams <[email protected]> * Fix vscode-php-debug publisher name and name in meta.yaml Signed-off-by: Eric Williams <[email protected]> * Re-introduce php-debugger, deprecate and set correct plugin as migrateTo Signed-off-by: Eric Williams <[email protected]> * Fixup description and remove extra line Signed-off-by: Eric Williams <[email protected]>
…he#676) * Move sidecar definitions into the plugin registry Part 1 of the migration. I am doing it in parts because doing it all at once will likely cause a build timeout upon pushing. Part of eclipse-che/che#18217 Signed-off-by: Eric Williams <[email protected]> * Handle java and java8 separately Signed-off-by: Eric Williams <[email protected]>
Includes fixes to the before-start.sh script to prevent shellcheck failures. Signed-off-by: Eric Williams <[email protected]>
Signed-off-by: sideeffffect <[email protected]>
|
deprecated by #685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sideeffffect [email protected]