fix cachedirs ownership #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Esteban Mañaricua <[email protected]>
gattytto
requested review from
benoitf,
ericwill,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
This fixes che-dockerfiles/che-sidecar-scala#10, right? |
|
@ericwill yes partially, then https://github.com/eclipse/che-plugin-registry/pull/668/files goes around updating the extension version, deprecating the old one and removing cache volumes to keep sidecar contents, and then when this one is merged that one should be updated to reflect the new sidecar id |
ericwill
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Esteban Mañaricua [email protected]
Signed-off-by: Esteban Mañaricua [email protected]