This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Add tests related to backward compatibility for single-root workspaces #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
==========================================
+ Coverage 29.45% 31.33% +1.88%
==========================================
Files 277 277
Lines 9336 9362 +26
Branches 1380 1392 +12
==========================================
+ Hits 2750 2934 +184
+ Misses 6487 6331 -156
+ Partials 99 97 -2
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
[crw-ci-test] |
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
|
[crw-ci-test] |
RomanNikitenko
requested review from
benoitf,
ericwill,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
[crw-ci-test --rebuild] |
benoitf
approved these changes
Apr 13, 2021
|
I guess I can merge the PR - there are successful jobs:
or should I wait for |
|
[crw-ci-test --rebuild] |
|
@RomanNikitenko yes, one job to rule them all :-) if one happy path test is ok, you win ! |
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Nikitenko [email protected]
What does this PR do?
Add tests related to backward compatibility for single-root workspaces
Screenshot/screencast of this PR
What issues does this PR fix or reference?
related to eclipse-che/che#19551
How to test this PR?
the tests should pass successfully
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next