Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Release images for ARM64 #1090

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

odidev
Copy link

@odidev odidev commented Apr 22, 2021

Added .github/workflows/build-publish-next-arm64.yml to build and release the image for ARM46 platform.

Updated .github/workflows/build-publish-next.yml, build.include, .github/workflows/happy-path-tests.yaml, .github/workflows/pr.yml, dockerfiles/build.include and dockerfiles/theia/build.sh to build amd64 and arm64 images.

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #1090 (f96e093) into master (eeb4526) will increase coverage by 1.94%.
The diff coverage is 56.33%.

❗ Current head f96e093 differs from pull request most recent head 9b7687e. Consider uploading reports for the commit 9b7687e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
+ Coverage   29.45%   31.39%   +1.94%     
==========================================
  Files         277      277              
  Lines        9336     9405      +69     
  Branches     1380     1408      +28     
==========================================
+ Hits         2750     2953     +203     
+ Misses       6487     6450      -37     
+ Partials       99        2      -97     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <ø> (ø)
...ovisioner/src/node/git-configuration-controller.ts 0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts 0.00% <0.00%> (ø)
...-che-theia-plugin-remote/src/node/plugin-remote.ts 0.00% <0.00%> (ø)
...plugin-remote/src/node/terminal-container-aware.ts 0.00% <0.00%> (ø)
...a-plugin-remote/src/node/webviews-content-aware.ts 0.00% <0.00%> (ø)
...che-theia-remote-api/src/common/devfile-service.ts 0.00% <ø> (ø)
...e-theia-remote-api/src/common/workspace-service.ts 0.00% <ø> (ø)
...er/src/node/che-server-certificate-service-impl.ts 0.00% <0.00%> (ø)
...-impl-k8s/src/node/k8s-certificate-service-impl.ts 0.00% <0.00%> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5bdd67...9b7687e. Read the comment docs.

@benoitf
Copy link
Contributor

benoitf commented Apr 22, 2021

Hello @odidev and thanks for the contribution.

it seems we may not need to add a separate workflow for every build as the full idea with multi-arch is to submit as well multi-arch images on the OCI registry (instead of having some images with a suffix like -arm64, another -ppc64le, etc.

in some che repositories we're using as well the PLATFORMS file to add the list of platforms
like
https://github.com/eclipse-che/che-devfile-registry/blob/master/PLATFORMS

so probably if you could tweak the build.include to use buildx command if some flag is given

Also, with buildx, do you the time it takes to build the image for arm64 emulator ?

@odidev
Copy link
Author

odidev commented May 7, 2021

Hi,
As per your suggestion, I have amended my changes for the development of docker images for multiple platforms.

@benoitf
Copy link
Contributor

benoitf commented Jun 23, 2021

hello, I think that it'll be handle as part of the effort to build also Power and Z images like in #1127

@che-bot
Copy link
Contributor

che-bot commented Jun 23, 2021

Can one of the admins verify this patch?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants