Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Fix lint errors in tests #23216

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[Test] Fix lint errors in tests #23216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/e2e/specs/api/EmptyWorkspaceAPI.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,11 @@ suite('Empty workspace API test', function (): void {
suiteSetup(`Create empty workspace with OC client ${BASE_TEST_CONSTANTS.TEST_ENVIRONMENT}`, async function (): Promise<void> {
const workspaceName: string = 'empty-' + Math.floor(Math.random() * 1000);
const devfileContent: string = 'schemaVersion: 2.2.0\n' + 'metadata:\n' + ` name: ${workspaceName}\n`;
const editorContent:string='';
const editorContent: string = '';

devWorkspaceConfigurationHelper = new DevWorkspaceConfigurationHelper({
devfileContent, editorContent
devfileContent,
editorContent
});
devfileContext = await devWorkspaceConfigurationHelper.generateDevfileContext();
devWorkspaceName = devfileContext?.devWorkspace?.metadata?.name;
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/specs/miscellaneous/UserSecretsInWorkspace.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ suite('"User secrets in workspace" test', function (): void {
);
const shellExecutor: ShellExecutor = e2eContainer.get(CLASSES.ShellExecutor);
const testWorkspaceUtil: ITestWorkspaceUtil = e2eContainer.get(TYPES.WorkspaceUtil);
const userProject: string = OAUTH_CONSTANTS.TS_SELENIUM_OCP_USERNAME + `-devspaces`;
const userProject: string = OAUTH_CONSTANTS.TS_SELENIUM_OCP_USERNAME + '-devspaces';
const stackName: string = 'Empty Workspace';

const mountEnvCommand: string = `echo '
Expand Down Expand Up @@ -72,7 +72,7 @@ type: Opaque
await projectAndFileTests.waitWorkspaceReadinessForCheCodeEditor();
});

test('Check that mounted secret exists in envs list', async function (): Promise<void> {
test('Check that mounted secret exists in envs list', function (): void {
kubernetesCommandLineToolsExecutor = e2eContainer.get(CLASSES.KubernetesCommandLineToolsExecutor);
kubernetesCommandLineToolsExecutor.workspaceName = WorkspaceHandlingTests.getWorkspaceName();
kubernetesCommandLineToolsExecutor.loginToOcp();
Expand Down
1 change: 0 additions & 1 deletion tests/e2e/utils/DevWorkspaceConfigurationHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { IContextParams } from './IContextParams';
import { e2eContainer } from '../configs/inversify.config';
import { CLASSES, EXTERNAL_CLASSES } from '../configs/inversify.types';
import getDecorators from 'inversify-inject-decorators';
import {DevfilesHelper} from "./DevfilesHelper";

const { lazyInject } = getDecorators(e2eContainer);

Expand Down
Loading